OIDC backend jwks#1838
Draft
AaronPlave wants to merge 2 commits into
Draft
Conversation
| } catch (e) { | ||
| console.error(e); | ||
| } catch (error) { | ||
| console.error(error); |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Adds OIDC verification (asymmetric/JWKS – e.g. Keycloak RS256) to the two backend services that validate bearer tokens directly, the action server (TypeScript) and the workspace server (Java), alongside the existing symmetric (HMAC/SSO) path. Both read the same
HASURA_GRAPHQL_JWT_SECRET.key(HMAC) or ajwk_url(JWKS). The secret is validated up front (exactly one ofkey/jwk_url, algorithm family must match the mode), and the verification algorithm is pinned, so an RS public key can't be abused as an HMAC secret.withAnyOfAudience, matching jsonwebtoken's array behavior)issuerand the legacyissaliasusernameclaim, falling back tox-hasura-user-idin the Hasura claims namespace (OIDC tokens), so both servers attribute a request to the same user.audiencearray elementskid(Key ID) floods can't hammer the IdPVerification
tests/app.test.mts,tests/authConfig.test.mts) –x-hasura-user-idusername fallback and issuer validation via the legacyissfield. workspace-server (JWTServiceTest.java, new) – identity resolution, role validation, issuer match/mismatch, and audience checks.Documentation
HASURA_GRAPHQL_JWT_SECRETnow accepts OIDC fields –jwk_url,issuer/iss,audience(string or array), and asymmetrictypevalues (RS256/RS384/RS512) in addition to the existing{ type: "HS*", key }form. Any deployment/env docs describing this secret should be updated to cover the JWKS configuration.Future work