Upgrade Apache Commons Configuration to 2.x to fix CVE-2025-46392#1591
Open
jordanpadams wants to merge 1 commit intomainfrom
Open
Upgrade Apache Commons Configuration to 2.x to fix CVE-2025-46392#1591jordanpadams wants to merge 1 commit intomainfrom
jordanpadams wants to merge 1 commit intomainfrom
Conversation
Replaces the vulnerable commons-configuration:commons-configuration:1.10 with org.apache.commons:commons-configuration2:2.14.0. Updates imports and query() to use the 2.x builder/fluent API with DefaultListDelimiterHandler. Fixes NASA-PDS/outlaw-tracker#23 Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
nutjob4life
requested changes
Apr 25, 2026
Member
nutjob4life
left a comment
There was a problem hiding this comment.
Did something break as a result of commons-configuration upgrade? Or something else? I ran maven test twice but got this each time:
[ERROR] Failures:
[ERROR] CucumberTest.Example #1.184: NASA-PDS/validate#84-1 Test Failed Due To Exception: Cannot invoke "gov.nasa.pds.validate.report.Report.getWriter()" because "this.report" is null
[ERROR] CucumberTest.Example #1.185: NASA-PDS/validate#84-2 Test Failed Due To Exception: Cannot invoke "gov.nasa.pds.validate.report.Report.getWriter()" because "this.report" is null
[INFO]
[ERROR] Tests run: 334, Failures: 2, Errors: 0, Skipped: 23
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Upgrades
commons-configuration:commons-configuration:1.10(CVE-2025-46392) toorg.apache.commons:commons-configuration2:2.14.0.Changes:
pom.xml: Replacecommons-configuration:commons-configuration:1.10withorg.apache.commons:commons-configuration2:2.14.0ValidateLauncher.java: Update imports toorg.apache.commons.configuration2.*and migratequery()to use the 2.xFileBasedConfigurationBuilder/DefaultListDelimiterHandlerfluent API (the 1.xAbstractConfiguration.setDefaultListDelimiter()static call is not available in 2.x)🤖 AI Assistance Disclosure
Estimated % of code influenced by AI: 80%
⚙️ Test Data and/or Report
mvn compilepasses cleanly.mvn test -Dtest=ValidationIntegrationTestspasses (BUILD SUCCESS, 23 tests). Existing test suite exercises thequery()code path via config-file-driven integration tests.♻️ Related Issues
Fixes NASA-PDS/outlaw-tracker#23
🤓 Reviewer Checklist
Reviewers: Please verify the following before approving this pull request.
Documentation and PR Content
Security & Quality
Testing & Validation
Maintenance