[capgen-v1] Require positive evidence before treating index_of_<X> as a constituent index - #780
Merged
climbfuji merged 7 commits intoSep 4, 2026
Conversation
…s a component of an internal constituent even though there was no constituent for it
dustinswales
approved these changes
Sep 3, 2026
dustinswales
left a comment
dustinswales
left a comment
Contributor
There was a problem hiding this comment.
@climbfuji This looks good to me. Thanks for making these changes.
peverwhee
requested changes
Sep 3, 2026
peverwhee
left a comment
peverwhee
left a comment
Collaborator
There was a problem hiding this comment.
a possible request and the usual "courtney is confused by this comment" stuff
Co-authored-by: Courtney Peverley <courtneyp@ucar.edu>
…esolver.py: guard against schemes writing to a constituent index variable
…m/climbfuji/ccpp-framework into bugfix/index_of_not_a_constituent
climbfuji
force-pushed
the
bugfix/index_of_not_a_constituent
branch
from
September 3, 2026 23:09
3886458 to
23fc258
Compare
…tituent; catch invalid metadat (index_of_... plus constituent = True)
peverwhee
approved these changes
Sep 4, 2026
peverwhee
left a comment
peverwhee
left a comment
Collaborator
There was a problem hiding this comment.
thanks @climbfuji !
I'm still confused on some of the constituent handling; however, we'll have to rethink things when we remove build-time constituents anyway, so I'm happy to approve this.
Collaborator
Author
Appreciate your thorough review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #779.
The prefix is now a precondition, not a classifier. Auto-provisioning requires
positive evidence that
Xis a constituent — some scheme flaggingXortendency_of_Xasadvected/constituent/molar_mass. Without it, the nameis an ordinary variable and resolution raises the normal missing-provider
error. A suite-wide assertion re-checks the invariant after resolution so a
future path cannot reintroduce the class of bug.
No host changes required: the only
intent(in)-only CAM-SIMA name is declaredin
src/data/registry.xml, and the other eight haveintent=outproducers.Included are updates to
doc/*that are optional to review - they are usedprimarily as instructions and memory for the LLM. These will be removed
or moved elsewhere when feature/capgen-v1 eventually becomes develop.
Testing
index_of_Issues
Fixes #779