Fixing small problems experienced on Windows 10#57
Open
gabrielfreire wants to merge 15 commits intoNHDaly:masterfrom
Open
Fixing small problems experienced on Windows 10#57gabrielfreire wants to merge 15 commits intoNHDaly:masterfrom
gabrielfreire wants to merge 15 commits intoNHDaly:masterfrom
Conversation
…nclude win_installer into ApplicationBuilder.jl and set cpu_target default to nothing
…andline_app script
… variables for command line tool
…Windows, added extra option to choose installer compiler for Windows ISS/NSIS
Owner
|
Hi @gabrielfreire. Sorry for the super long delay. I honestly don't have any experience with this kind of thing, and I don't really know how to review it. The premise seems reasonable. Perhaps we could enlist help from @ranjanan to review, who wrote most of the windows code here? ❤️ Or, also, @KristofferC, will PackageCompilerX end up covering support for creating a windows installer like this? Or is this something you want to keep in a separate package (like maybe this package?)? I admit I haven't been doing much maintenance on ApplicationBuilder.jl recently... Is absorbing ApplicationBuilder part of the roadmap for PackageCompilerX as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes as per #56