Skip to content

feat: introduction screen#1655

Open
pedroafmonteiro wants to merge 21 commits intodevelopfrom
feature/introduction-screen
Open

feat: introduction screen#1655
pedroafmonteiro wants to merge 21 commits intodevelopfrom
feature/introduction-screen

Conversation

@pedroafmonteiro
Copy link
Copy Markdown
Member

Closes #1511

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 7%. Comparing base (7268a4c) to head (6b2a6c5).
⚠️ Report is 1 commits behind head on develop.

❌ Your project check has failed because the head coverage (7%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1655   +/-   ##
=======================================
- Coverage        7%      7%   -0%     
=======================================
  Files           38      38           
  Lines         1842    1876   +34     
=======================================
  Hits           125     125           
- Misses        1717    1751   +34     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pedroafmonteiro pedroafmonteiro self-assigned this Sep 24, 2025
@pedroafmonteiro pedroafmonteiro changed the title Introduction Screen feat: introduction screen Sep 27, 2025
@pedroafmonteiro pedroafmonteiro marked this pull request as ready for review March 31, 2026 09:59
Copy link
Copy Markdown

@joaolopes15 joaolopes15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the duplicated code and taking out the default introduction screen (for already logged in users) looks good to go.


if (savedSession != null) {
return '/${NavigationItem.navPersonalArea.route}';
return '/${NavigationItem.navIntroduction.route}';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just modify to not introduce in every app launch (just before merging)

Comment on lines +224 to +229
if (mounted) {
setState(() {
_loggingIn = true;
_intercepting = false;
});
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: introduction screen

3 participants