-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add more info to teacher's modal #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PedroLunet
wants to merge
35
commits into
develop
Choose a base branch
from
addmoreInfoToTeachersModal
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
c2bbb25
updated minimumOSVersion
PedroLunet 86e4725
uncommented code
PedroLunet f6f1753
updated parser and sheet
PedroLunet 7fc25be
updated rooms fetching logic
PedroLunet cfd1e99
fixed emial fetch logic
PedroLunet 3c2df5c
simplified email fetch logic
PedroLunet e1b0eae
added shimmer
PedroLunet b968af7
add professor schedule support to SchedulePage
PedroLunet e71ada9
add navProfessorSchedule route
PedroLunet b820949
register professor schedule route
PedroLunet b28dc81
show professor schedule in-app instead of external link
PedroLunet 37c0451
Merge branch 'develop' into addmoreInfoToTeachersModal
PedroLunet b377e6f
Merge branch 'develop' into addmoreInfoToTeachersModal
pedroafmonteiro ba00179
Merge branch 'develop' into addmoreInfoToTeachersModal
pedroafmonteiro 8754710
refactor: Remove institutional email and rooms fields and their extra…
PedroLunet 912fb8e
Refactor: Extract professor extra information fetching logic into a d…
PedroLunet 32ab148
refactor: extract `_ShimmerInfoRow` into a new, reusable `ShimmerInfo…
PedroLunet 99360e9
refactor: separate professor schedule display into its own page and f…
PedroLunet 75bec0c
reverted changes on schedule_page
PedroLunet 769998b
refactor: update widget constructors to use super.key and clean up im…
PedroLunet 40bc85e
fixed lint
PedroLunet f46b052
Merge branch 'develop' into addmoreInfoToTeachersModal
pedroafmonteiro 3672a46
Merge branch 'develop' into addmoreInfoToTeachersModal
PedroLunet 05daa11
removed unnecessary data duplication
PedroLunet 68ef74b
refactored modal
PedroLunet 8c6a234
removed duplicated logic
PedroLunet 0858c73
removed duplicated (or more) classes
PedroLunet 899d30f
fix lint
PedroLunet ce686d7
Merge branch 'develop' into addmoreInfoToTeachersModal
PedroLunet a514bb8
Merge branch 'develop' into addmoreInfoToTeachersModal
PedroLunet c9138bd
refactor: professor_info_provider - keep FutureProvider.family due to…
PedroLunet 3167eaa
refactor: replace ProfessorLecturesParams class with record type
PedroLunet 27d67a7
refactor: simplify deduplication in professorLecturesProvider
PedroLunet fd59585
fix: update shimmer_info_row colors for dark mode support
PedroLunet e26680f
fix: improve icon contrast in course unit info modal
PedroLunet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PedroLunet marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.