Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor SGLang Rollout with the New Design
Overview
This PR refactors the SGLang rollout stack to support the new rollout architecture while preserving backward compatibility with the previous interface.
The new design focuses on improving scalability, reliability, and maintainability of the rollout system. In particular, it introduces support for:
async def generate_async(...)for asynchronous multi-turn rolloutThe goal is to make the rollout layer production-ready for larger-scale serving and training integration, while minimizing disruption to existing callers.
Tests:
Thorough tests(around 75 tests):