Skip to content

feat(sft): make only_unmask_final configurable in SFTConfig #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ai-chan-0411 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

feat(sft): make only_unmask_final configurable in SFTConfig #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/configs/sft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ sft:
val_at_start: true
val_at_end: false
seed: 42
only_unmask_final: false

checkpointing:
enabled: true
Expand Down
3 changes: 3 additions & 0 deletions nemo_rl/algorithms/sft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ class SFTConfig(TypedDict):
# final checkpoint has validation metrics, which is required for get_best_checkpoint_path().
val_at_end: bool
seed: int
only_unmask_final: bool


class MasterConfig(TypedDict):
Expand Down Expand Up @@ -267,6 +268,7 @@ def validate(
add_loss_mask_to_message_log(
val_batch["message_log"],
roles_to_train_on=["assistant"],
only_unmask_final=master_config["sft"]["only_unmask_final"],
)

cat_and_padded, input_lengths = batched_message_log_to_flat_message(
Expand Down Expand Up @@ -430,6 +432,7 @@ def sft_train(
add_loss_mask_to_message_log(
batch["message_log"],
roles_to_train_on=["assistant"],
only_unmask_final=master_config["sft"]["only_unmask_final"],
)

cat_and_padded, input_lengths = batched_message_log_to_flat_message(
Expand Down
Loading