Skip to content

ci: pass quality gate when test_level is none (lint-only PRs)#2276

Open
ko3n1g wants to merge 3 commits intomainfrom
ko3n1g/ci/qa-gate-none-fix
Open

ci: pass quality gate when test_level is none (lint-only PRs)#2276
ko3n1g wants to merge 3 commits intomainfrom
ko3n1g/ci/qa-gate-none-fix

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Apr 16, 2026

Summary

Fixes the CI_QA_Gate always failing for PRs that have no CI label (e.g. docs-only or workflow-only changes).

Root cause

ALL_SUCCESS required test_level != 'none' as part of a conjunction, so when no tests were scheduled the entire condition evaluated to false — even if lint passed cleanly. The comment above the expression already said "Job is considered successful if nothing was run", but the logic didn't implement that.

Fix

Replace test_level != 'none' && <all jobs passed> with test_level == 'none' || <all jobs passed>, which correctly short-circuits to true when no tests were scheduled.

Before / After

-              needs.pre-flight.outputs.test_level != 'none' &&
-              needs.sphinx-build.result == 'success' &&
+              needs.pre-flight.outputs.test_level == 'none' ||
+              (
+                needs.sphinx-build.result == 'success' &&
               ...
+              )

Unblocks

Test plan

  • This PR itself should pass the quality gate with test_level = none

ko3n1g added 3 commits April 16, 2026 11:52
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested review from a team as code owners April 16, 2026 12:09
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 16, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the CI Relating to CI label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant