ci: pass quality gate when test_level is none (lint-only PRs)#2276
Open
ci: pass quality gate when test_level is none (lint-only PRs)#2276
Conversation
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
CI_QA_Gatealways failing for PRs that have no CI label (e.g. docs-only or workflow-only changes).Root cause
ALL_SUCCESSrequiredtest_level != 'none'as part of a conjunction, so when no tests were scheduled the entire condition evaluated tofalse— even if lint passed cleanly. The comment above the expression already said "Job is considered successful if nothing was run", but the logic didn't implement that.Fix
Replace
test_level != 'none' && <all jobs passed>withtest_level == 'none' || <all jobs passed>, which correctly short-circuits totruewhen no tests were scheduled.Before / After
Unblocks
Test plan
test_level = none