Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Modifications for using Flask >=0.11 if available#1550

Open
samikama wants to merge 4 commits into
NVIDIA:masterfrom
samikama:master
Open

Modifications for using Flask >=0.11 if available#1550
samikama wants to merge 4 commits into
NVIDIA:masterfrom
samikama:master

Conversation

@samikama
Copy link
Copy Markdown

Hello,
Two tiny modifications to be able to use more recent versions Flask, if user updated local installation for other purposes.

Cheers,
Sami

@samikama
Copy link
Copy Markdown
Author

Local execution of digits-lint seems to behave differently than in travis tests.. Curious

@lukeyeager
Copy link
Copy Markdown
Member

Local execution of digits-lint seems to behave differently than in travis tests.. Curious

It'll depend on which version of flake8 you have.

Comment thread digits/views.py Outdated
# in werkzeug default_exceptions are valid
# [400, 401, 403, 404, 405, 406, 408, 409, 410,
# 411, 412, 413, 414, 415, 416, 417, 418, 422,
# 423, 428, 429, 431, 451, 500, 501, 502, 503, 504, 505]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any value in enumerating all these status codes.

@lukeyeager
Copy link
Copy Markdown
Member

Thanks for the PR @samikama! Can you send us a CLA?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants