Forward-merge release/0.4 into main#264
Merged
Merged
Conversation
#### Overview Adds configurable NeMo Relay CLI gateway body limits so oversized hook and passthrough payloads fail explicitly instead of surfacing opaque extractor or buffering errors. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Adds default gateway limits of 20MiB for coding-agent hook payloads and 100MiB for provider passthrough request bodies. - Exposes both limits through CLI flags, environment variables, and `[gateway]` config.toml fields. - Maps oversized hook and passthrough requests to structured `413 Payload Too Large` JSON responses. - Updates CLI dry-run output and docs to show the new gateway limit settings. - Adds regression coverage for defaults, config parsing, CLI/env validation, large hook acceptance, and structured 413 responses. Validation: - `cargo fmt --all --check` - `git diff --check` - `cargo test -p nemo-relay-cli` #### Where should the reviewer start? Start with `crates/cli/src/config.rs` for the public configuration surface, then `crates/cli/src/server.rs` and `crates/cli/src/gateway.rs` for the hook and passthrough enforcement paths. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Closes #255 - Relates to RELAY-297 ## Summary by CodeRabbit * **New Features** * Added configurable maximum payload size limits for hook payloads and passthrough body requests via CLI arguments, environment variables, and TOML configuration * Implemented HTTP 413 error responses when payloads exceed configured limits * **Documentation** * Updated configuration documentation with new gateway payload size limit options Authors: - Will Killian (https://github.com/willkill07) Approvers: - https://github.com/mnajafian-nv - https://github.com/lvojtku URL: #261
Author
|
SUCCESS - forward-merge complete. |
github-actions
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.4 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.