Skip to content

fix(e2e): correct return type of _stub_with_token#1897

Merged
johntmyers merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:fix/oidc-stub-return-type
Jun 13, 2026
Merged

fix(e2e): correct return type of _stub_with_token#1897
johntmyers merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:fix/oidc-stub-return-type

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

_stub_with_token returns a tuple[OpenShellStub, list[tuple[str, str]]]
but was annotated as OpenShellStub.
This caused 31 mypy errors cascading to every call site.
1-line fix to match the actual return value.

@mesutoezdil mesutoezdil requested review from a team, derekwaynecarr and mrunalp as code owners June 13, 2026 10:13
@copy-pr-bot

copy-pr-bot Bot commented Jun 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mesutoezdil mesutoezdil force-pushed the fix/oidc-stub-return-type branch from 20da3b4 to f337b7e Compare June 13, 2026 10:15
@TaylorMutch

Copy link
Copy Markdown
Collaborator

/ok to test f337b7e

@johntmyers johntmyers added the gator:approval-needed Gator completed review; maintainer approval needed label Jun 13, 2026
@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

Maintainer Approval Needed

Gator validation and PR monitoring are complete.

Validation: This is a small, concentrated E2E typing fix that matches _stub_with_token's actual return shape.
Review: Independent code review found no blocking correctness, security, maintainability, or missing-test issues at head f337b7ec37873b1df2d9cc414712ecd83696a67a.
Docs: Not needed; this does not change user-facing behavior or Fern-documented UX.
Checks: Required branch, DCO, Python, Rust, license, markdown, lockfile, and Helm gate statuses are passing.
E2E: No test:* label is required for this test-only annotation fix; E2E/GPU gate statuses are passing with those suites not applied.

Human maintainer approval or merge decision is now required.

@johntmyers johntmyers merged commit ec197a4 into NVIDIA:main Jun 13, 2026
29 checks passed
@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Final status: PR #1897 was in gator:approval-needed; maintainer approval was recorded, required gate statuses were passing, and the PR merged at 2026-06-13T21:21:00Z.

I removed the active gator:* label because there is nothing left for gator to monitor on this PR.

@johntmyers johntmyers removed the gator:approval-needed Gator completed review; maintainer approval needed label Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants