[https://nvbugs/6018647][test] Add unit test for Lifecycle Race Condition error in disagg sever#12803
[https://nvbugs/6018647][test] Add unit test for Lifecycle Race Condition error in disagg sever#12803yingguo-trt wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
…m lifecycle Add regression test StoreBlocksForReuseWithPinDoesNotCreateGhostFreeBlocks to verify that storeBlocksForReuse(pin=true) correctly calls claimBlock() on zero-ref blocks before incRefCount(), preventing duplicate free queue entries that caused hangs and crashes in disaggregated serving with block reuse enabled. Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a regression test case that validates KV-cache block lifecycle behavior when block reuse and pinning are enabled together, ensuring no "ghost free" blocks inflate free-block counts during Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #42122 [ run ] triggered by Bot. Commit: |
|
/bot run |
|
PR_Github #42134 [ run ] triggered by Bot. Commit: |
|
PR_Github #42134 [ run ] completed with state
|
|
/bot run --skip-test |
|
PR_Github #42226 [ run ] triggered by Bot. Commit: |
|
PR_Github #42226 [ run ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #42244 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #42244 [ reuse-pipeline ] completed with state |
Add regression test StoreBlocksForReuseWithPinDoesNotCreateGhostFreeBlocks to verify that storeBlocksForReuse(pin=true) correctly calls claimBlock() on zero-ref blocks before incRefCount(), preventing duplicate free queue entries that caused hangs and crashes in disaggregated serving with block reuse enabled.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.