-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[None][infra] Upgrade xgrammar and lock pillow #12812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuanjingx87
wants to merge
7
commits into
NVIDIA:release/1.3.0rc5.post2
Choose a base branch
from
yuanjingx87:user/yuanjingx/bump_xgrammar
base: release/1.3.0rc5.post2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
41bf342
Bump xgrammar
yuanjingx87 89a6154
[TRTLLM-11135][fix] Fix vulnerability aiohttp (#11778)
yiqingy0 2cc6190
[https://nvbugs/5941242][fix] Fix SigLIP test failure (#12717)
tijyojwad 2f5a980
[https://nvbugs/5979673][fix] improve NIXL agent import error diagnos…
Shixiaowei02 c15eac0
Waive failed A10-PyTorch-1 test in pre-merge
yuanjingx87 b465baa
[None][infra] use public torch index as CI backup (#12261)
tburt-nv a0c2bbc
Update wheelDocker images
yuanjingx87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- a/cpp/grammar_functor.cc | ||
| +++ b/cpp/grammar_functor.cc | ||
| @@ -1750,11 +1750,11 @@ | ||
| void Apply(Grammar* grammar); | ||
| static std::optional<uint64_t> HashSequence(const Grammar& grammar, int32_t sequence_id); | ||
|
|
||
| - static const int16_t kNotEndStateFlag = -0x100; | ||
| - static const int16_t kEndStateFlag = -0x200; | ||
| - static const int16_t kSelfRecursionFlag = -0x300; | ||
| - static const int16_t kSimpleCycleFlag = -0x400; | ||
| - static const int16_t kUnKnownFlag = -0x500; | ||
| + static constexpr int16_t kNotEndStateFlag = -0x100; | ||
| + static constexpr int16_t kEndStateFlag = -0x200; | ||
| + static constexpr int16_t kSelfRecursionFlag = -0x300; | ||
| + static constexpr int16_t kSimpleCycleFlag = -0x400; | ||
| + static constexpr int16_t kUnKnownFlag = -0x500; | ||
|
|
||
| private: | ||
| Grammar* grammar_; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| regex | ||
| fire | ||
| tritonclient[all] | ||
| transformers==4.57.1 | ||
| transformers==4.57.3 | ||
| pandas | ||
| tabulate | ||
| flash_attn | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thorjohnsen I thought we wanted to pin this to 0.6.4 because of some additional issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security_scanning is auto-generated and be cherry-picked, it is only for nspect scanning, this should not affect trtllm itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual version to be locked is defined here https://github.com/yuanjingx87/TensorRT-LLM/blob/89a6154838305eee8a074761d5341b10208511df/requirements.txt#L57