[https://nvbugs/6055847][fix] Preserve Nemotron HF mamba cache dtype in bench tuning#12826
[https://nvbugs/6055847][fix] Preserve Nemotron HF mamba cache dtype in bench tuning#12826hyukn wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
📝 WalkthroughWalkthroughUpdated conditional logic in benchmark utility for configuring Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tensorrt_llm/bench/benchmark/utils/general.py`:
- Around line 114-116: Formatting-only change required: run the project
formatter (yapf/pre-commit) on the file containing the conditional that checks
isinstance(model_config, NemotronHybridConfig) and mamba_ssm_cache_dtype, commit
the resulting formatting-only modifications, and push them to unblock CI; do not
alter logic in the if statement or surrounding functions—only apply the
automated formatting and include the formatted file in this PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cffb9f9b-66ef-40d6-8ad5-3a8dfbf55cfe
📒 Files selected for processing (1)
tensorrt_llm/bench/benchmark/utils/general.py
| if isinstance( | ||
| model_config, NemotronHybridConfig | ||
| ) and mamba_ssm_cache_dtype not in (None, "auto"): |
There was a problem hiding this comment.
Run formatter and commit the result to unblock CI
This change appears functionally correct, but CI is currently blocked by formatting (pre-commit reported yapf modified this file). Please run the formatter and include the formatting-only update in this PR.
As per coding guidelines, "Code formatting is handled by automatic tooling; do not override it unless it substantially improves readability."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@tensorrt_llm/bench/benchmark/utils/general.py` around lines 114 - 116,
Formatting-only change required: run the project formatter (yapf/pre-commit) on
the file containing the conditional that checks isinstance(model_config,
NemotronHybridConfig) and mamba_ssm_cache_dtype, commit the resulting
formatting-only modifications, and push them to unblock CI; do not alter logic
in the if statement or surrounding functions—only apply the automated formatting
and include the formatted file in this PR.
…in bench tuning Avoid overriding Nemotron hybrid mamba_ssm_cache_dtype with auto during benchmark settings generation, so heuristics keep the HF-configured float32 cache dtype unless the user explicitly overrides it. Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #42291 [ run ] triggered by Bot. Commit: |
|
PR_Github #42291 [ run ] completed with state
|
Summary by CodeRabbit
Bug Fixes
Description
Avoid overriding Nemotron hybrid mamba_ssm_cache_dtype with auto during benchmark settings generation, so heuristics keep the HF-configured float32 cache dtype unless the user explicitly overrides it.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.