upgrade_controller: nil-check DrainSpec before dereferencing PodSelector#2419
Closed
SAY-5 wants to merge 1 commit intoNVIDIA:mainfrom
Closed
upgrade_controller: nil-check DrainSpec before dereferencing PodSelector#2419SAY-5 wants to merge 1 commit intoNVIDIA:mainfrom
SAY-5 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Closes NVIDIA#2417. ClusterPolicy with autoUpgrade:true and no drain section panics the upgrade controller every reconcile. Signed-off-by: SAY-5 <say.apm35@gmail.com>
SAY-5
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
SAY-5
force-pushed
the
fix/upgrade-drainspec-nil-2417
branch
from
cdcdaf5 to
51c240f
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2417. ClusterPolicy with
autoUpgrade: trueand nodrainsection hadUpgradePolicy.DrainSpec == nil; thePodSelectoraccess panicked every reconcile. Initialize the spec on first use.