docs: fix CRITICAL and MAJOR findings from E2E docs audit#283
Merged
ArangoGutierrez merged 5 commits intoNVIDIA:mainfrom Apr 7, 2026
Merged
Conversation
- Dockerfile: copy all .go files (*.go) instead of only main.go, fixing build failure after bridge_tests.go was added in PR NVIDIA#269 (C2) - go.mod: update Go version from 1.23 to 1.25 to match root module (m5) Found by docs E2E audit agents. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
- workflow_dispatch default golang_version: 1.23 → 1.25 (M4) - Clarify GPU Operator images are public; standalone GFD/validator steps (if: false) may need auth for nvcr.io standalone images (M5) - Update tests/e2e/README.md to remove stale NGC credential claims Found by docs E2E audit agents. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
…ides CRITICAL fixes: - C1: GPU Operator section now self-contained — inlined nvidia-container-toolkit install, CDI mode configuration, and containerd restart steps that were previously behind a 'see the E2E workflow' reference MAJOR fixes: - M2: DRA prerequisites: Kubernetes 1.31+ → 1.32+ (matches chart constraint) - M3: GPU Operator helm install: removed nfd.enabled=false and operator.defaultRuntime=containerd flags that diverge from CI - M6: Multi-node section expanded from brief snippet to complete 7-step Quick Start (Kind create, image build, nvidia-ctk loop, helm installs with --wait --timeout, device plugin deploy, GPU verification with polling, cleanup) Found by docs E2E audit agents. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
CRITICAL fixes: - C3: Added nodeSelector to helm install restricting DaemonSet to integration pool nodes instead of running everywhere - C4: Aligned topology ConfigMap schema — both docs now use nodeGroups/gpuModel (was nodePools/gpuProfile in demo README) MAJOR fixes: - M7: Converted 'kubectl apply -f topology.yaml' (nonexistent file) to heredoc that creates the ConfigMap inline MINOR fixes: - m8: Added cleanup section to integration guide - m14: Added namespace: gpu-operator to topology ConfigMap metadata Found by docs E2E audit agents. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
MAJOR fixes: - M1: --stats output corrected from 400/111 to 396/107 (stubs 289 unchanged) MINOR fixes: - m1: Added missing files to project tree: bridge/events.go, engine/invalid_device.go, engine/version.go, config files, updated docs/ directory structure Found by docs E2E audit agents. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
End-to-end docs audit found 4 CRITICAL, 7 MAJOR, and 14 MINOR findings across all documentation paths. This PR fixes all CRITICAL and MAJOR findings, plus several MINOR ones.
Findings Fixed
CRITICAL
MAJOR
MINOR (included)
Files Changed (8)