Skip to content

Update install-ci.yml#1531

Open
coreyjadams wants to merge 2 commits intomainfrom
coreyjadams-python-3.14-support
Open

Update install-ci.yml#1531
coreyjadams wants to merge 2 commits intomainfrom
coreyjadams-python-3.14-support

Conversation

@coreyjadams
Copy link
Copy Markdown
Collaborator

@coreyjadams coreyjadams commented Mar 24, 2026

This commit hits several items:

  • update version for several actions to quiet node js version 20 warnings.
  • enable python 3.14(159) for nightly CI.
  • does not pivot PR install CI away from 3.13.

I'm putting this on the main repo so we can test it here, rather than on my fork.

This pr will fix #1516

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

This commit hits several items:
- update version for several actions to quiet node js version 20 warnings.
- enable python 3.14(159) for nightly CI.
- does _not_ pivot PR install CI away from 3.13.

I'm putting this on the main repo so we can test it here, rather than on my fork.
Allow python 3.14
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 24, 2026

Greptile Summary

This PR updates .github/workflows/install-ci.yml to bump GitHub Actions versions, add Python 3.14 to nightly CI, and drop the v2.0-refactor branch from the PR trigger list. The action upgrades (actions/checkout@v4→v6, actions/setup-python@v5→v6) are valid, released versions that address Node.js v20 deprecation warnings. Python 3.14 (released October 2025) is correctly added only to the push and scheduled/manual matrix entries, leaving PR CI on 3.12 only.

  • actions/checkout bumped from v4 to v6 (latest: v6.0.2).
  • actions/setup-python bumped from v5 to v6 (latest: v6.1.0); note that v6 requires runner v2.327.1 or later — verify your self-hosted or GitHub-hosted runners meet this minimum if applicable.
  • Python 3.14 added to push (ubuntu only) and schedule/workflow_dispatch (ubuntu, ubuntu-24.04-arm, macos-latest, windows-latest) matrix entries.
  • v2.0-refactor removed from PR trigger branches.
  • The inline comment describing the matrix job counts (lines 47–50) is now stale and undercounts jobs after the 3.14 additions.

Important Files Changed

Filename Overview
.github/workflows/install-ci.yml Updates action versions (checkout v4→v6, setup-python v5→v6), removes v2.0-refactor PR trigger branch, and adds Python 3.14 to nightly/push CI matrix. A stale comment on job counts and Python version references is the only minor issue.

Comments Outside Diff (1)

  1. .github/workflows/install-ci.yml, line 47-50 (link)

    P2 Stale job count/version comments

    The matrix description comment now has incorrect job counts and an outdated Python version reference after adding Python 3.14:

    • push now runs 4 jobs (3.11, 3.12, 3.13, 3.14), not 3.
    • schedule/manual now runs 10 jobs, not 6.
    • The arm/mac/win platforms now test both 3.13 and 3.14, not just 3.13.

Reviews (1): Last reviewed commit: "Update pyproject.toml" | Re-trigger Greptile

Copy link
Copy Markdown
Collaborator

@peterdsharpe peterdsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look in-concept good to me. Thanks for implementing this! Now we just need to get TransformerEngine to play nice in CI! 😅

@peterdsharpe
Copy link
Copy Markdown
Collaborator

/blossom-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀[FEA]: Python 3.14 Support

2 participants