Skip to content

Fix Warp deprecation warnings and broken links in Mesh README#1564

Open
manmeet3591 wants to merge 1 commit intoNVIDIA:mainfrom
manmeet3591:fix-warp-dep-and-links
Open

Fix Warp deprecation warnings and broken links in Mesh README#1564
manmeet3591 wants to merge 1 commit intoNVIDIA:mainfrom
manmeet3591:fix-warp-dep-and-links

Conversation

@manmeet3591
Copy link
Copy Markdown

@manmeet3591 manmeet3591 commented Apr 13, 2026

This PR addresses two maintenance items:

  1. Warp Deprecation Fix: Replaces wp.context.Device with wp.Device in radius_search/_warp_impl.py to resolve upcoming namespace removals in NVIDIA Warp.
  2. README Link Fixes: Corrects several broken relative links in physicsnemo/mesh/README.md that were redundantly prefixed with physicsnemo/mesh/ or had incorrect relative paths to examples/ and test/.

Signed-off-by: Manmeet Singh <manmeet20singh11@gmail.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 13, 2026

Greptile Summary

This is a small maintenance PR that fixes two independent issues: it replaces the deprecated wp.context.Device with wp.Device in _warp_impl.py (affecting function signatures and docstrings in count_neighbors and gather_neighbors), and corrects broken relative links in physicsnemo/mesh/README.md so that module and resource links resolve correctly relative to the file's location.

Important Files Changed

Filename Overview
physicsnemo/nn/functional/neighbors/radius_search/_warp_impl.py Replaces deprecated wp.context.Device with wp.Device in function signatures and docstrings for count_neighbors and gather_neighbors; no logic changes.
physicsnemo/mesh/README.md Fixes broken relative links: module subdirectory links now use ./ prefix, and examples//test/ are corrected to ../../examples/ and ../../test/mesh/ respectively.

Reviews (1): Last reviewed commit: "Fix: Warp deprecation warnings and broke..." | Re-trigger Greptile

Copy link
Copy Markdown
Collaborator

@peterdsharpe peterdsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me on the Mesh README.md side, approving!

@loliverhennigh can double-check the wp.Device fix (where he's CODEOWNER), but I think this is correct syntax.

Looks like one minor CI issue from markdownlint to fix before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants