-
Notifications
You must be signed in to change notification settings - Fork 283
from_protobuf (part 1): Add ordinal remapping for GetStructField/GetArrayStructFields #14499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thirtiseven
wants to merge
3
commits into
NVIDIA:main
Choose a base branch
from
thirtiseven:struct-field-meta-infra
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
sql-plugin/src/test/scala/com/nvidia/spark/rapids/StructFieldOrdinalTagSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| /* | ||
| * Copyright (c) 2026, NVIDIA CORPORATION. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.nvidia.spark.rapids | ||
|
|
||
| import org.scalatest.funsuite.AnyFunSuite | ||
|
|
||
| import org.apache.spark.sql.catalyst.expressions.{ | ||
| AttributeReference, | ||
| GetArrayStructFields, | ||
| GetStructField | ||
| } | ||
| import org.apache.spark.sql.rapids.{ | ||
| GpuGetArrayStructFieldsMeta, | ||
| GpuGetStructFieldMeta, | ||
| GpuStructFieldOrdinalTag | ||
| } | ||
| import org.apache.spark.sql.types._ | ||
|
|
||
| class StructFieldOrdinalTagSuite extends AnyFunSuite { | ||
|
|
||
| private val threeFieldStruct = StructType(Seq( | ||
| StructField("a", IntegerType, nullable = true), | ||
| StructField("b", StringType, nullable = true), | ||
| StructField("c", DoubleType, nullable = true))) | ||
|
|
||
| private val structAttr = AttributeReference("s", threeFieldStruct, nullable = true)() | ||
|
|
||
| private val arrayOfStruct = ArrayType(threeFieldStruct, containsNull = false) | ||
| private val arrayAttr = AttributeReference("arr", arrayOfStruct, nullable = true)() | ||
|
|
||
| // ---------- GetStructField ordinal tag ---------- | ||
|
|
||
| test("effectiveOrdinal returns original ordinal when no tag is set") { | ||
| val gsf = GetStructField(structAttr, 2, Some("c")) | ||
| assert(GpuGetStructFieldMeta.effectiveOrdinal(gsf) === 2) | ||
| } | ||
|
|
||
| test("effectiveOrdinal returns tagged ordinal when tag is set") { | ||
| val gsf = GetStructField(structAttr, 2, Some("c")) | ||
| gsf.setTagValue(GpuStructFieldOrdinalTag.PRUNED_ORDINAL_TAG, 0) | ||
| assert(GpuGetStructFieldMeta.effectiveOrdinal(gsf) === 0) | ||
| } | ||
|
|
||
| test("effectiveOrdinal ignores negative tag values") { | ||
| val gsf = GetStructField(structAttr, 1, Some("b")) | ||
| gsf.setTagValue(GpuStructFieldOrdinalTag.PRUNED_ORDINAL_TAG, -1) | ||
| assert(GpuGetStructFieldMeta.effectiveOrdinal(gsf) === 1) | ||
| } | ||
|
|
||
| // ---------- GetArrayStructFields ordinal tag ---------- | ||
|
|
||
| test("array struct effectiveOrdinal returns original ordinal when no tag") { | ||
| val gasf = GetArrayStructFields(arrayAttr, threeFieldStruct(1), 1, 3, false) | ||
| assert(GpuGetArrayStructFieldsMeta.effectiveOrdinal(gasf) === 1) | ||
| } | ||
|
|
||
| test("array struct effectiveOrdinal returns tagged ordinal when tag is set") { | ||
| val gasf = GetArrayStructFields(arrayAttr, threeFieldStruct(1), 1, 3, false) | ||
| gasf.setTagValue(GpuStructFieldOrdinalTag.PRUNED_ORDINAL_TAG, 0) | ||
| assert(GpuGetArrayStructFieldsMeta.effectiveOrdinal(gasf) === 0) | ||
| } | ||
|
|
||
| // ---------- effectiveNumFields ---------- | ||
|
|
||
| test("effectiveNumFields returns original numFields when no tag") { | ||
| val gasf = GetArrayStructFields(arrayAttr, threeFieldStruct(1), 1, 3, false) | ||
| val result = GpuGetArrayStructFieldsMeta.effectiveNumFields(arrayAttr, gasf, -1) | ||
| assert(result === 3) | ||
| } | ||
|
|
||
| test("effectiveNumFields derives from child type when tag is active") { | ||
| val prunedStruct = StructType(Seq( | ||
| StructField("b", StringType, nullable = true))) | ||
| val prunedArrayType = ArrayType(prunedStruct, containsNull = false) | ||
| val prunedChild = AttributeReference("arr", prunedArrayType, nullable = true)() | ||
|
|
||
| val gasf = GetArrayStructFields(arrayAttr, threeFieldStruct(1), 1, 3, false) | ||
| val result = GpuGetArrayStructFieldsMeta.effectiveNumFields(prunedChild, gasf, 0) | ||
| assert(result === 1) | ||
| } | ||
|
|
||
| test("effectiveNumFields falls back to expr.numFields for non-array child type") { | ||
| val nonArrayChild = AttributeReference("x", IntegerType, nullable = true)() | ||
| val gasf = GetArrayStructFields(arrayAttr, threeFieldStruct(0), 0, 3, false) | ||
| val result = GpuGetArrayStructFieldsMeta.effectiveNumFields(nonArrayChild, gasf, 0) | ||
| assert(result === 3) | ||
| } | ||
|
|
||
| // ---------- Tag independence ---------- | ||
|
|
||
| test("tags on different expressions are independent") { | ||
| val gsf1 = GetStructField(structAttr, 0, Some("a")) | ||
| val gsf2 = GetStructField(structAttr, 2, Some("c")) | ||
| gsf1.setTagValue(GpuStructFieldOrdinalTag.PRUNED_ORDINAL_TAG, 5) | ||
|
|
||
| assert(GpuGetStructFieldMeta.effectiveOrdinal(gsf1) === 5) | ||
| assert(GpuGetStructFieldMeta.effectiveOrdinal(gsf2) === 2) | ||
thirtiseven marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| test("tag can be overwritten") { | ||
| val gsf = GetStructField(structAttr, 2, Some("c")) | ||
| gsf.setTagValue(GpuStructFieldOrdinalTag.PRUNED_ORDINAL_TAG, 0) | ||
| assert(GpuGetStructFieldMeta.effectiveOrdinal(gsf) === 0) | ||
| gsf.setTagValue(GpuStructFieldOrdinalTag.PRUNED_ORDINAL_TAG, 1) | ||
| assert(GpuGetStructFieldMeta.effectiveOrdinal(gsf) === 1) | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.