Skip to content

compatibilty for tensorflow-v2#19

Open
ertza wants to merge 3 commits into
NVlabs:masterfrom
ertza:master
Open

compatibilty for tensorflow-v2#19
ertza wants to merge 3 commits into
NVlabs:masterfrom
ertza:master

Conversation

@ertza

@ertza ertza commented Apr 25, 2021

Copy link
Copy Markdown

pip only allows tensorflow>=2.2.0. This commit makes the code compatible to work with those versions.

@alkanen

alkanen commented May 10, 2021

Copy link
Copy Markdown

Why are the pyc files included? They are generated when you run python, they shouldn't be checked in.

@alkanen

alkanen commented May 10, 2021

Copy link
Copy Markdown

The same goes for the gazillian dataset files. They're not part of the code base, and some of them are huge.
And you've included images as well.

Did you just do "git add *" in the working directory?

@alkanen alkanen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be merged. The code changes might be fine, but the ~90 completely unrelated files that shouldn't be here to begin with aren't.

@ertza

ertza commented May 10, 2021

Copy link
Copy Markdown
Author

Sorry these commits are not to be pulled into the main branch, they are a custom commit for my mirror of the repo. Only the first one was the one intended to be a pull request. Please ignore the other commits.

@alkanen

alkanen commented May 10, 2021

Copy link
Copy Markdown

Sorry these commits are not to be pulled into the main branch, they are a custom commit for my mirror of the repo. Only the first one was the one intended to be a pull request. Please ignore the other commits.

Gotcha! Then please disregard my rather harsh comments :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants