Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7emansell
commented
Apr 13, 2026
| resourceEndpointDetails: AnyBibDetail[], | ||
| annotatedMarcDetails: AnyMarcDetail[] | ||
| ): AnyBibDetail[] { | ||
| // Merge series added entry and series uniform title fields |
Collaborator
Author
There was a problem hiding this comment.
Annoying but this has to happen somewhere, other than merging parallels into primaries this is the only thing on the bib where we munge two fields together into one ... this felt like the clearest juncture to do it at
Contributor
There was a problem hiding this comment.
This logic is def a candidate to move to the discovery API. Would you want to make that update?
Collaborator
Author
There was a problem hiding this comment.
discussed offline, will continue to do this here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
seriesUniformTitleandseriesAddedEntry, removingseriesStatement)How has this been tested?
Good example bibs (they have been correctly indexed as of 4/16):
b11603668
b22098736
b22697988
b21979887
b11018902
b19705975
b14477060
b16470373
b16470380
Accessibility concerns or updates
Checklist: