Skip to content

Fix regression #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Napsty merged 2 commits into from
May 9, 2026
Merged

Fix regression #119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f815662
Fix regression with symlink paths
Napsty May 9, 2026
f6d7a97
Fix regression with symlink paths
Napsty May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions check_smart.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,15 @@
# Dec 15, 2025: Philippe Beaumont - Add areca devices (6.17.0)
# Apr 21, 2026: Claudio Kuenzler - Fix sys path for sudo command. Detect NVME input/output error (6.18.0)
# Apr 24, 2026: Claudio Kuenzler - Fix command injection vulnerability in interface parameter (6.18.1)
# May 9, 2026: Claudio Kuenzler - Fix regression with symlink paths (6.18.2)

use strict;
use Getopt::Long;
use File::Basename qw(basename);
use Cwd qw(abs_path);

my $basename = basename($0);
my $revision = '6.18.1';
my $revision = '6.18.2';

# Standard Nagios return codes
my %ERRORS=('OK'=>0,'WARNING'=>1,'CRITICAL'=>2,'UNKNOWN'=>3,'DEPENDENT'=>4);
Expand Down Expand Up @@ -160,7 +162,14 @@
foreach my $opt_dl (@dev){
warn "(debug) Found $opt_dl\n" if $opt_debug;
if (-l $opt_dl) {
warn "(debug) $opt_dl is a symlink, skipping for security reasons\n" if $opt_debug;
# Resolve symlink and use the real path to prevent command injection
my $real_path = abs_path($opt_dl);
if (defined($real_path) && (-b $real_path || -c $real_path)) {
warn "(debug) $opt_dl is a symlink to block device $real_path, using resolved path\n" if $opt_debug;
$device .= $real_path."|";
} else {
warn "(debug) $opt_dl is a symlink not pointing to a valid block device, skipping\n" if $opt_debug;
}
} elsif (-b $opt_dl || -c $opt_dl || $opt_dl =~ m/^\/dev\/bus\/\d$/) {
$device .= $opt_dl."|";
} else {
Expand Down