Add HLSL compilation support#89
Draft
ArthurVasseur wants to merge 3 commits intoNazaraEngine:mainfrom
Draft
Conversation
ArthurVasseur
commented
Mar 31, 2026
- Updated Compiler.cpp to include HLSL compilation options and methods.
- Added CompileToHLSL function
- Enhanced command-line options to support HLSL version specification.
- Created HlslTests.cpp to validate HLSL output
- Extended ShaderUtils to include ExpectHLSL
- Updated Compiler.cpp to include HLSL compilation options and methods. - Added CompileToHLSL function - Enhanced command-line options to support HLSL version specification. - Created HlslTests.cpp to validate HLSL output - Extended ShaderUtils to include ExpectHLSL
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 76.91% 75.22% -1.69%
==========================================
Files 200 204 +4
Lines 25126 26764 +1638
Branches 7747 8343 +596
==========================================
+ Hits 19325 20133 +808
- Misses 5701 6529 +828
- Partials 100 102 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
|
That's really great, thanks a lot. However before I can consider merging to the main branch:
|
Contributor
This seems quite easy to do with a Transformer. The only problem is finding a clever way to let the user know which bindings have been changed. |
Use the directxshadercompiler package (optional, Windows/Linux only) to compile each generated HLSL output through DXC (SM 6.6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.