Skip to content

privateCodes implemented (partically) in all functional elements the first is now in the privateCodes part.#811

Closed
ue71603 wants to merge 8 commits intonextfrom
use-privateCodes
Closed

privateCodes implemented (partically) in all functional elements the first is now in the privateCodes part.#811
ue71603 wants to merge 8 commits intonextfrom
use-privateCodes

Conversation

@ue71603
Copy link
Copy Markdown
Contributor

@ue71603 ue71603 commented Dec 4, 2024

use privateCodes and no longer the depreciated PrivateCode:
#597

First version: Should it be done this way for all examples?

@ue71603 ue71603 added the enhancement non semantic enhacement: technical enhancement, etc. label Dec 4, 2024
@ue71603 ue71603 added this to the netex_2.0 milestone Dec 4, 2024
@ue71603 ue71603 requested review from Aurige and skinkie December 4, 2024 12:37
@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Dec 4, 2024

The problem is 'with all examples' the obviously might be examples where it is not the first element. But give it a shot, if this is automatic. I think we can fix the exceptions more easily.

@ue71603
Copy link
Copy Markdown
Contributor Author

ue71603 commented Dec 4, 2024

It never is. It is always in a different position, but I think the number is not too big

@ue71603
Copy link
Copy Markdown
Contributor Author

ue71603 commented Dec 4, 2024

and having "most". would also be enough in my view.

@Aurige
Copy link
Copy Markdown
Contributor

Aurige commented Dec 4, 2024

That's fine to me.
That's also something that we can do in a longer run: fixing the examples does not require a CEN NWI or a document update ... so we can directly update master whenever we find a new one to be fixed.

@ue71603 ue71603 self-assigned this Feb 5, 2025
@ue71603 ue71603 added the fix_now label Apr 3, 2025
@ue71603 ue71603 changed the title First draft of using privateCodes privateCodes implemented (partically) in all functional elements the first is now in the privateCodes part. Apr 9, 2025
@ue71603 ue71603 requested review from TuThoThai and trurlurl April 9, 2025 17:32
@ue71603
Copy link
Copy Markdown
Contributor Author

ue71603 commented Apr 23, 2025

superseeded by #872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement non semantic enhacement: technical enhancement, etc. fix_now

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants