add toggle to demote disabled and suspended apps - #2636
Open
druneau wants to merge 1 commit into
Open
Conversation
marunjar
requested changes
Aug 12, 2026
| if (canAddToHistory()) { | ||
| SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context); | ||
| boolean demoteDisabled = prefs.getBoolean("demote-disabled-apps", true); | ||
| if (canAddToHistory() || (!demoteDisabled && pojo.isDisabled())) { |
Collaborator
There was a problem hiding this comment.
Why is this necessary?
From option itself i would not expect this functionality to be changed too.
Only priority of results should change IMO.
| if (pojo.isDisabled()) { | ||
| // Give penalty for disabled items, these should not be preferred | ||
| pojo.relevance -= 200; | ||
| if (demoteDisabled) { |
Collaborator
There was a problem hiding this comment.
Please don't forget about else branch.
Condition should be same as in HistorySearcher to have same behaviour as when isDisabled returns false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KISS currently automatically demotes suspended and disabled apps from search results. This PR adds the ability to toggle this behaviour "off".
I added this for myself because i use digital well being features to basically suspend almost all apps after 5 minutes. And this feature allows me to quickly open them up through KISS search restuls when required.
Tested on google pixel 9a.
AI was used to make the changes.