Bump tensorboard to 2.21.0, setuptools to 83.0.0 - #1658
Open
dxqb wants to merge 1 commit into
Open
Conversation
tensorboard 2.21.0 no longer imports the pkg_resources API removed in setuptools 82, so the `setuptools<82` constraint is no longer needed. setuptools stays pinned like everything else in requirements-global.txt, just moved to the current 83.0.0. The bootstrap steps in lib.include.sh and update.bat pinned setuptools to 81.0.0 to stay under that constraint; both are bumped to 83.0.0 so the bootstrap installs the intended version directly. Fixes Nerogar#1307. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Yeah; I think the latest TensorBoard doesn't take setuptools as a dep, so we can remove it completely; and it will be obsolete after #1244 since the lockfile does the pinning for transitive deps; we should only pin top-level ones. |
Contributor
|
See 03251e2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tensorboard 2.21.0 no longer imports the
pkg_resourcesAPI removed in setuptools 82, so thesetuptools<82constraint added in #1305 is no longer needed. setuptools stays pinned like everything else inrequirements-global.txt, just moved to the current 83.0.0.The pip/setuptools bootstrap in
lib.include.shandupdate.batpinned setuptools to 81.0.0 to stay under that constraint; both are bumped to 83.0.0 so the bootstrap installs the intended version directly.Fixes #1307.
probably waiting on #1244 to not cause any more unnecessary conflicts, or might even be obsolete after #1244?
@hameerabbasi
AI assistance