Confirm before clearing the cache on training start - #1660
Open
dxqb wants to merge 1 commit into
Open
Conversation
"Clear cache before training" is a sticky flag, so leaving it ticked from a previous run silently deletes the cache directory contents when the next run starts. Start Training now asks for confirmation first, and cancelling aborts the start before the button switches to the training state. The cache directory can be on a remote machine, so there is no way to check whether a cache exists or to offer a separate "delete now" action. The prompt is gated on latent caching as well, matching the condition under which GenericTrainer.start actually clears the cache. Adds a confirm(title, message) -> bool method to BaseTrainUIView, backed by messagebox.askokcancel in the CustomTkinter view and QMessageBox.question in the PySide6 view. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pre-commit run --all-filespassesAI assistance