Skip to content

Replace manual casts on pattern with instanceof #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abdelhak-zaaim wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −6
Open

Replace manual casts on pattern with instanceof #1559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8428f8
Replace manual casts on pattern with instanceof
abdelhak-zaaim Oct 17, 2024
d141698
Update RateLimitingFilter.java
abdelhak-zaaim Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions eureka-core/src/main/java/com/netflix/eureka/RateLimitingFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2014 Netflix, Inc.
* Copyright 2014, 2024 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -149,8 +149,7 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha

private static Target getTarget(ServletRequest request) {
Target target = Target.Other;
if (request instanceof HttpServletRequest) {
HttpServletRequest httpRequest = (HttpServletRequest) request;
if (request instanceof HttpServletRequest httpRequest) {
String pathInfo = httpRequest.getRequestURI();

if ("GET".equals(httpRequest.getMethod()) && pathInfo != null) {
Expand Down
4 changes: 1 addition & 3 deletions eureka-core/src/main/java/com/netflix/eureka/ServerRequestAuthFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ public void destroy() {

protected void logAuth(ServletRequest request) {
if (serverConfig.shouldLogIdentityHeaders()) {
if (request instanceof HttpServletRequest) {
HttpServletRequest httpRequest = (HttpServletRequest) request;

if (request instanceof HttpServletRequest httpRequest) {
String clientName = getHeader(httpRequest, AbstractEurekaIdentity.AUTH_NAME_HEADER_KEY);
String clientVersion = getHeader(httpRequest, AbstractEurekaIdentity.AUTH_VERSION_HEADER_KEY);

Expand Down