Add rebranding UI - #188
Draft
andre8244 wants to merge 7 commits into
Draft
Conversation
edospadoni
deployed
to
add-rebranding-ui - my-backend-qa PR #188
September 1, 2026 15:28 — with
Render
Active
edospadoni
requested a deployment
to
add-rebranding-ui - my-frontend-qa PR #188
September 1, 2026 15:28 — with
Render
In progress
Contributor
|
🔗 Redirect URIs Added to Logto The following redirect URIs have been automatically added to the Logto application configuration: Redirect URIs:
Post-logout redirect URIs:
These will be automatically removed when the PR is closed or merged. |
The browser chrome lived inside LoginScreenPreview, so the top bar view was drawn as a bare page and the favicon had nowhere to show. Extract it into BrowserChrome and mount it in the panel, above whichever view is selected: the product is a web app either way, and the canvas now reads as one screenshot in both. The canvas background and aria-hidden move up to the panel with it, so each view no longer repeats them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
A customer belongs to a reseller or directly to a distributor, but the filter on the customers page was scoped to resellers, leaving the customers of a distributor unreachable from it. The organization search now takes a list of types and sends one repeatable type parameter per value, which the backend already OR-s, and the customers page asks for distributors and resellers together. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
andre8244
force-pushed
the
add-rebranding-ui
branch
from
September 1, 2026 15:28
8171e4b to
938e440
Compare
The company combobox asked for every organization and then kept only those of the allowed types. That page is truncated at 50 rows ordered by name, and customers outnumber partners, so the allowed companies could fall outside it: the "created on behalf of" field offered few or no options, and the check that decides whether to render it at all failed the same way, hiding the field with nothing to explain why. Both now pass the allowed types to the search, which the backend accepts as a repeatable parameter. Sharing those types also keeps the check and the field on one query key, so they still make one request. The excluded ids stay a client-side filter: the API has no equivalent, and removing a known id cannot silently empty the list. Assisted-by: Claude Code:Opus 5 (1M context)
edospadoni
deployed
to
add-rebranding-ui - my-frontend-qa PR #188
September 2, 2026 07:27 — with
Render
Active
The view was picked from a combobox and the theme from a toggle button, so two controls of the same kind — a choice between two known options — looked and behaved differently, and neither showed the alternative without being opened or clicked. Both are now NeRadioSelection, with the theme options labelled by the state they select rather than the one they switch to. Assisted-by: Claude Code:Opus 5 (1M context)
The card listed the interfaces in the order the inventory happened to serialize them, so a system with several of them read as an unordered pile and the same appliance could reshuffle between reports. They are now sorted by name, with numeric collation so eth2 precedes eth10 instead of following it. Assisted-by: Claude Code:Opus 5 (1M context)
edospadoni
deployed
to
add-rebranding-ui - my-frontend-qa PR #188
September 2, 2026 08:32 — with
Render
Active
Every on/off row rendered its own icon and colour, so one state appeared in three greens (green-600, green-700, icon-enabled) and two greys, with two icon pairs for the same boolean. Add EnabledStatus, owning the icon pair, the colour tokens, the spacing and the default labels, and use it for the six two-state rows: the rebranding row of the customer, reseller, distributor and application info cards, the additional services card and the notification channel cards. The application row gives up its badge so all four rebranding rows now match. Rename --icon-disabled to --icon-neutral, since it marks a neutral state (suspended, archived, unknown, not purchased) rather than a disabled control, and set its light value to gray-600. Point every status and muted icon at --icon-enabled or --icon-neutral, dropping the dark: twins the tokens make redundant. Body text and the amber and rose states keep their literal colours. Assisted-by: Claude Code:Opus 5 (1M context)
edospadoni
deployed
to
add-rebranding-ui - my-frontend-qa PR #188
September 2, 2026 10:42 — with
Render
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
Add rebranding UI
Related Issue: #[ISSUE_NUMBER]
🚀 Testing Environment
To trigger a fresh deployment of all services in the PR preview environment, comment:
Automatic PR environments:
✅ Merge Checklist
Code Quality:
Builds: