docs(agents): guideline for avoiding test duplication#11546
Open
LukaszRozmej wants to merge 1 commit intomasterfrom
Open
docs(agents): guideline for avoiding test duplication#11546LukaszRozmej wants to merge 1 commit intomasterfrom
LukaszRozmej wants to merge 1 commit intomasterfrom
Conversation
Add to AGENTS.md "Coding guidelines and style": - Avoid code duplication, especially in tests - Parameterize with [TestCase]/[TestCaseSource] when tests differ only by inputs - Extract helper methods/types when only parts of tests are similar Extend .agents/rules/test-infrastructure.md "Test guidelines": - Concrete patterns for partial duplication: helper methods, builders, base fixtures, shared static helpers - Note when to prefer [TestCaseSource] over [TestCase] Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
benaadams
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AGENTS.md"Coding guidelines and style" — new bullet on avoiding code duplication, especially in tests:[TestCase(...)]/[TestCaseSource(...)]when tests differ only by inputs/expected valuestest-infrastructure.mdfor the concrete patterns.agents/rules/test-infrastructure.md"Test guidelines" — extend the existing TestCase/TestCaseSource rules with concrete patterns for partial duplication:Build.A.Block...,TestItem.*) or private helpers[SetUp][TestCaseSource]over[TestCase](non-constant data, named scenarios, grows beyond a handful)Complements PR #11544 which added the comments / XML-doc guidance. Same kind of cross-cutting agent rule, kept in a separate PR for clean review.
Types of changes
Testing
Requires testing
Documentation
Requires documentation update
Requires explanation in Release Notes