Skip to content

[Zarr-Support] Add Zarr v2 reader support #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ehennestad wants to merge 3 commits into
base: main
Choose a base branch
from

Improve read performance

e3151f5
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

[Zarr-Support] Add Zarr v2 reader support #821

Improve read performance
e3151f5
Select commit
Loading
Failed to load commit list.
GitHub Actions / JUnit Test Report failed Apr 21, 2026 in 0s

583 tests run, 571 passed, 11 skipped, 1 failed.

Annotations

Check failure on line 1 in +tests/+unit/nwbReadTest.m

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

nwbReadTest.readFileWithInvalidTimeSeriesTimestampsShape 

Assertion failed in tests.unit.nwbReadTest/readFileWithInvalidTimeSeriesTimestampsShape and it did not run to completion.
    ----------------
Raw output 
Assertion failed in tests.unit.nwbReadTest/readFileWithInvalidTimeSeriesTimestampsShape and it did not run to completion.
    ----------------
    Test Diagnostic:
    ----------------
    Expected nwbRead to fail when timestamps are 2-D.
    ------------------
    Stack Information:
    ------------------
    In /home/runner/work/matnwb/matnwb/+tests/+unit/nwbReadTest.m (nwbReadTest.readFileWithInvalidTimeSeriesTimestampsShape) at 125Verification failed in tests.unit.nwbReadTest/readFileWithInvalidTimeSeriesTimestampsShape.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyEqual failed.
    --> The character arrays are not equal.
    
    Actual char:
        MATLAB:unittest:Assertable:AssertionFailed
    Expected char:
        NWB:createParsedType:TypeCreationFailed
    ------------------
    Stack Information:
    ------------------
    In /home/runner/work/matnwb/matnwb/+tests/+unit/nwbReadTest.m (nwbReadTest.readFileWithInvalidTimeSeriesTimestampsShape) at 127Verification failed in tests.unit.nwbReadTest/readFileWithInvalidTimeSeriesTimestampsShape.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifySubstring failed.
    --> The value does not contain the substring.
    
    Actual char:
        Assertion failed.
    Expected Substring:
        Failed to create object of type "types.core.TimeSeries"
    ------------------
    Stack Information:
    ------------------
    In /home/runner/work/matnwb/matnwb/+tests/+unit/nwbReadTest.m (nwbReadTest.readFileWithInvalidTimeSeriesTimestampsShape) at 129Verification failed in tests.unit.nwbReadTest/readFileWithInvalidTimeSeriesTimestampsShape.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifySubstring failed.
    --> The value does not contain the substring.
    
    Actual char:
        Assertion failed.
    Expected Substring:
        file location "/acquisition/bad_ts"
    ------------------
    Stack Information:
    ------------------
    In /home/runner/work/matnwb/matnwb/+tests/+unit/nwbReadTest.m (nwbReadTest.readFileWithInvalidTimeSeriesTimestampsShape) at 131Verification failed in tests.unit.nwbReadTest/readFileWithInvalidTimeSeriesTimestampsShape.
    ---------------------
    Framework Diagnostic:
    ---------------------
    verifyNotEmpty failed.
    --> The value must not be empty.
    --> The value has a size of [0  0].
    
    Actual Value:
      0×0 empty cell array
    ------------------
    Stack Information:
    ------------------
    In /home/runner/work/matnwb/matnwb/+tests/+unit/nwbReadTest.m (nwbReadTest.readFileWithInvalidTimeSeriesTimestampsShape) at 133Error occurred in tests.unit.nwbReadTest/readFileWithInvalidTimeSeriesTimestampsShape and it did not run to completion.
    ---------
    Error ID:
    ---------
    'MATLAB:badsubscript'
    --------------
    Error Details:
    --------------
    Index exceeds array bounds.
    
    Error in tests.unit.nwbReadTest/readFileWithInvalidTimeSeriesTimestampsShape (line 134)
                    testCase.verifySubstring(exception.cause{1}.message, ...
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
View more details on GitHub Actions