Skip to content

Change to accept delay_sec as 0 sec #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kawasin73 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change to accept delay_sec as 0 sec #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kale/publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def publish(self, task_class, task_id, payload,

sqs_queue.send_message(
MessageBody=kale_msg.encode(),
DelaySeconds=delay_sec or 1
DelaySeconds=delay_sec or 0

@timnd timnd Dec 11, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more appropriate backwards compatible change would be to change the default value in the parameter list to delay_sec=1 and remove the delay_sec is not None check above (L35). The parameter is an int therefore None can be expected to raise a TypeError. Then change this line to DelaySeconds=delay_sec.

)

logger.debug('Published task. Task id: %s; Task name: %s' % (
Expand Down