Skip to content

Adds DLQ tag to created queues #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corydolphin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adds DLQ tag to created queues #69

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5008ce
Adds DLQ tag to created queues
corydolphin Jul 12, 2021
626a7bb
Update version.py
corydolphin Jul 13, 2021
288da13
Merge pull request #1 from corydolphin/patch-1
corydolphin Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kale/publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def publish_messages_to_dead_letter_queue(self, dlq_name, messages):
:raises: SendMessagesException: SQS responded with a partial success. Some
messages were not delivered.
"""
sqs_dead_letter_queue = self._get_or_create_queue(dlq_name)
sqs_dead_letter_queue = self._get_or_create_queue(dlq_name, is_dlq=True)

response = sqs_dead_letter_queue.send_messages(
Entries=[{
Expand Down
7 changes: 4 additions & 3 deletions kale/sqs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,13 @@ def __init__(self, *args, **kwargs):
self._client = self._session.client('sqs', endpoint_url=endpoint_url)
self._sqs = self._session.resource('sqs', endpoint_url=endpoint_url)

def _get_or_create_queue(self, queue_name):
def _get_or_create_queue(self, queue_name, is_dlq=False):
"""Fetch or create a queue.

:param str queue_name: string for queue name.
:param bool is_dlq:True iff the queue is a dead letter queue and should be tagged as such
:return: Queue
:rtype: boto3.resources.factory.sqs.Queue
:rtype: boto3.resources.factory.sqs.Queue
"""

# Check local cache first.
Expand All @@ -76,7 +77,7 @@ def _get_or_create_queue(self, queue_name):
raise e

logger.info('Creating new SQS queue: %s' % queue_name)
queue = self._client.create_queue(QueueName=queue_name)
queue = self._client.create_queue(QueueName=queue_name, tags={"dlq":str(is_dlq)})

@corydolphin corydolphin Jul 12, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags looks to be lower case in the Boto3 docs, however inconsistent. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sqs.html#SQS.Client.create_queue

queue_url = queue.get('QueueUrl')

# create queue object
Expand Down