Skip to content

Do executor recovery in chunks to fix #718 #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efonsell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do executor recovery in chunks to fix #718 #719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions nflow-engine/src/main/java/io/nflow/engine/internal/dao/WorkflowInstanceDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,11 +399,16 @@ public void recoverWorkflowInstancesFromDeadNodes() {
}
WorkflowInstanceAction.Builder builder = new WorkflowInstanceAction.Builder().setExecutionStart(now()).setExecutionEnd(now())
.setType(recovery).setStateText("Recovered");
for (InstanceInfo instance : getRecoverableWorkflowInstances(recoverableExecutorIds)) {
WorkflowInstanceAction action = builder.setState(instance.state()).setWorkflowInstanceId(instance.id()).build();
recoverWorkflowInstance(instance.id(), instance.executorId(), action);
List<Integer> recoverableExecutorIdList = new ArrayList<>(recoverableExecutorIds);
for (int from = 0; from < recoverableExecutorIdList.size(); from += 100) {
List<Integer> recoverableExecutorIdChunk = recoverableExecutorIdList.subList(from,
min(from + 100, recoverableExecutorIdList.size()));
for (InstanceInfo instance : getRecoverableWorkflowInstances(recoverableExecutorIdChunk)) {
WorkflowInstanceAction action = builder.setState(instance.state()).setWorkflowInstanceId(instance.id()).build();
recoverWorkflowInstance(instance.id(), instance.executorId(), action);
}
recoverableExecutorIdChunk.forEach(executorInfo::markRecovered);
}
recoverableExecutorIds.forEach(executorInfo::markRecovered);
}

private List<InstanceInfo> getRecoverableWorkflowInstances(Collection<Integer> executorsIds) {
Expand Down
Loading