Various packaging improvements#12033
Conversation
we are not testing any nixos modules, so we don't need to generate documentation. This will give us a bit of speed up.
|
Fails on the formatting check (pre-commit). Is that consistent with the failure you got in the upgrade? |
|
(i.e. |
github-actions
Bot
added
the
with-tests
|
Forgot to cherry-pick also the header update. |
| clang-format = { | ||
| enable = true; | ||
| # https://github.com/cachix/git-hooks.nix/pull/532 | ||
| package = pkgs.llvmPackages_latest.clang-tools; |
There was a problem hiding this comment.
What's the impact of this on the devshell closure size? (It's already pretty big, depending on gcc, clang and a lot of other stuff.)
There was a problem hiding this comment.
Same as the current clang-tools version. But we need both macOS and Linux to use the same version. Open for other suggestions, but it will increase the closure size on some platform for sure if it's not the same as default included one on one platform or the other. I sticked to _latest because it will never go out-of-date compared to pinning a version.
There was a problem hiding this comment.
Not having this will block our nixpkgs upgrade.
There was a problem hiding this comment.
Actually on Linux it will likely not change anything, I assume. Because there shouldn't be clang included in the gcc build anyway. It will increase it for macOS.
3 participants
Motivation
Cherry picked from: #11566
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.