libpsl-with-scripts: init as override of libpsl#350833
Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom Feb 13, 2025
Merged
libpsl-with-scripts: init as override of libpsl#350833Ericson2314 merged 1 commit intoNixOS:stagingfrom
Ericson2314 merged 1 commit intoNixOS:stagingfrom
Conversation
ofborg
Bot
requested review from
amiloradovsky,
bjornfor,
c0bw3b,
gebner and
prusnak
ofborg
Bot
added
10.rebuild-darwin: 501+
bjornfor
reviewed
Oct 24, 2024
Contributor
bjornfor
left a comment
bjornfor
left a comment
There was a problem hiding this comment.
LGTM, but I have no idea what libpsl is, so I'll defer to others.
wegank
added
the
2.status: merge conflict
rhelmot
force-pushed
the
libpsl-no-scripts
branch
2 times, most recently
from
6147aa3 to
35d05a7
Compare
Contributor
Author
|
Since I made this PR, another point in favor of this solution: #350819 |
ofborg
Bot
removed
the
2.status: merge conflict
wegank
added
the
2.status: merge conflict
rhelmot
force-pushed
the
libpsl-no-scripts
branch
from
35d05a7 to
d674c04
Compare
Member
|
Could have |
rhelmot
force-pushed
the
libpsl-no-scripts
branch
2 times, most recently
from
b38672f to
b99433f
Compare
Contributor
Author
|
Done! |
rhelmot
removed
the
2.status: merge conflict
rhelmot
force-pushed
the
libpsl-no-scripts
branch
from
b99433f to
4d44b3d
Compare
ofborg
Bot
added
the
2.status: merge conflict
psl-make-dafsa pulls in a runtime python3 dependency which seems to have given various build configurations no end of trouble. This solves the problem in the least subtle manner imaginable, by removing it for all platforms and re-adding it in a new package which currently has no dependants. Switch your dependency from libpsl to libpsl-with-scripts if you are impacted by this.
rhelmot
force-pushed
the
libpsl-no-scripts
branch
from
4d44b3d to
be9121f
Compare
ofborg
Bot
removed
the
2.status: merge conflict
Ericson2314
approved these changes
Feb 13, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Fantastic! Splitting packages to deal with optional deps, without causing stuff to be recompiled, is the best!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
psl-make-dafsa pulls in a runtime python3 dependency which seems to have given various build configurations no end of trouble. This solves the problem in the least subtle manner imaginable, by removing it for all platforms and re-adding it in a new package which currently has no dependencies. Switch your dependency from libpsl to libpsl-with-scripts if you are impacted by this.
ref #347007 #344211 #344209 #344157 #335458
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.