Skip to content

python312Packages.mmengine: fix test #353442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaetanLepage merged 1 commit into from
Nov 4, 2024
Merged

python312Packages.mmengine: fix test #353442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions pkgs/development/python-modules/mmengine/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@ buildPythonPackage rec {
url = "https://github.com/open-mmlab/mmengine/commit/4c22f78cdea2981a2b48a167e9feffe4721f8901.patch";
hash = "sha256-k+IFLeqTEVUGGiqmZg56LK64H/UTvpGN20GJT59wf4A=";
})
(fetchpatch2 {
# Bug reported upstream in https://github.com/open-mmlab/mmengine/issues/1575
# PR: https://github.com/open-mmlab/mmengine/pull/1589
name = "adapt-to-pytest-breaking-change";
url = "https://patch-diff.githubusercontent.com/raw/open-mmlab/mmengine/pull/1589.patch";
hash = "sha256-lyKf1GCLOPMpDttJ4s9hbATIGCVkiQhtyLfH9WzMWrw=";
})
];

build-system = [ setuptools ];
Expand All @@ -64,7 +71,7 @@ buildPythonPackage rec {
];

nativeCheckInputs = [
# bitsandbytes (broken as of 2024-07-06)
bitsandbytes
coverage
dvclive
lion-pytorch
Expand All @@ -77,7 +84,7 @@ buildPythonPackage rec {

preCheck =
''
export HOME=$TMPDIR
export HOME=$(mktemp -d)
''
# Otherwise, the backprop hangs forever. More precisely, this exact line:
# https://github.com/open-mmlab/mmengine/blob/02f80e8bdd38f6713e04a872304861b02157905a/tests/test_runner/test_activation_checkpointing.py#L46
Expand All @@ -95,14 +102,6 @@ buildPythonPackage rec {
"tests/test_runner/test_activation_checkpointing.py"
# missing dependencies
"tests/test_visualizer/test_vis_backend.py"
# Tests are outdated (runTest instead of run_test)
"mmengine/testing/_internal"
"tests/test_dist/test_dist.py"
"tests/test_dist/test_utils.py"
"tests/test_hooks/test_sync_buffers_hook.py"
"tests/test_model/test_wrappers/test_model_wrapper.py"
"tests/test_optim/test_optimizer/test_optimizer.py"
"tests/test_optim/test_optimizer/test_optimizer_wrapper.py"
];

disabledTests = [
Expand Down