rust-analyzer-unwrapped: 2024-09-02 -> 2024-11-11#354304
Merged
khaneliman merged 9 commits intoNixOS:masterfrom Nov 17, 2024
Merged
rust-analyzer-unwrapped: 2024-09-02 -> 2024-11-11#354304khaneliman merged 9 commits intoNixOS:masterfrom
khaneliman merged 9 commits intoNixOS:masterfrom
Conversation
khaneliman
force-pushed
the
rust-analyzer
branch
from
40d9b8e to
72192ef
Compare
khaneliman
changed the title
ofborg
Bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
Need to look into the neovim test failure. |
Contributor
|
The r-a binary works for my nvim/coc.nvim setup, and I couldn't reproduce the failure by running the test script with Could we disable that test for now? |
Contributor
Author
|
Contributor
Author
Yeah, looks like something recently affected the test environment. I can recreate the test failing on master, too. I'm just disabling it, for now. |
oxalica
suggested changes
Nov 16, 2024
khaneliman
force-pushed
the
rust-analyzer
branch
from
1125df6 to
aad2b60
Compare
Currently fails to find std lib in neovim environment so hover doesn't contain type information needed to successfully pass the test.
We don't need to define frameworks manually.
khaneliman
force-pushed
the
rust-analyzer
branch
from
aad2b60 to
2fa0afb
Compare
Contributor
Author
|
oxalica
approved these changes
Nov 17, 2024
Contributor
oxalica
left a comment
oxalica
left a comment
There was a problem hiding this comment.
Diff LGTM. Tested to work with neovim/coc.nvim.
`nixpkgs-review` result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 354304
x86_64-linux
✅ 4 packages built:
- ra-multiplex
- rust-analyzer
- rust-analyzer-unwrapped
- vscode-extensions.rust-lang.rust-analyzer
khaneliman
changed the title
wegank
added
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
https://github.com/rust-lang/rust-analyzer/releases/tag/2024-11-04
https://github.com/rust-lang/rust-analyzer/releases/tag/2024-11-11
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.