dnsdist: 1.9.8 -> 1.9.9#402865
Merged
LeSuisse merged 1 commit intoNixOS:masterfrom May 15, 2025
Merged
Conversation
matteo-pacini
previously approved these changes
Apr 29, 2025
Contributor
matteo-pacini
left a comment
There was a problem hiding this comment.
LGTM
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 402865 --package nixosTests.dnsdist --package dnsdist
x86_64-linux
✅ 2 tests built:
- nixosTests.dnsdist.base
- nixosTests.dnsdist.dnscrypt
✅ 1 package built:
- dnsdist
Stale, needs re-review because of new force-push
Member
Author
|
The force push was a rebase to clear a CI issue. Given this was initially approved and did not receive another review in the past 2 weeks, I'm going to merge this. |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-402865-to-release-24.11 origin/release-24.11
cd .worktree/backport-402865-to-release-24.11
git switch --create backport-402865-to-release-24.11
git cherry-pick -x f5c221fe72d34320c2b14381ec009d5c0e4ae27b |
Member
Author
|
24.11 is not affected as it uses DNSDist 1.8.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CVE-2025-30194.
https://www.dnsdist.org/changelog.html#change-1.9.9
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-review pr 402865aarch64-linux✅ 1 package built:
Add a 👍 reaction to pull requests you find important.