Skip to content

[24.11] feishin: 0.12.2 -> 0.12.6#406986

Merged
yayayayaka merged 2 commits intoNixOS:release-24.11from
teutat3s:feishin-backports
May 20, 2025
Merged

[24.11] feishin: 0.12.2 -> 0.12.6#406986
yayayayaka merged 2 commits intoNixOS:release-24.11from
teutat3s:feishin-backports

Conversation

@teutat3s
Copy link
Copy Markdown
Member

@teutat3s teutat3s commented May 14, 2025

Depends on #406425 for electron_36.

Related to #406422

Manual backports of
#388893
#405530

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@teutat3s
Copy link
Copy Markdown
Member Author

@ofborg eval

@teutat3s teutat3s force-pushed the feishin-backports branch from 77b98ff to 5f3d282 Compare May 14, 2025 22:01
@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 14, 2025
@nix-owners nix-owners Bot requested review from jlbribeiro and onny May 14, 2025 22:22
@teutat3s
Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406986


x86_64-linux

✅ 1 package built:
  • feishin

@teutat3s
Copy link
Copy Markdown
Member Author

@ofborg build feishin

Copy link
Copy Markdown
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the application on x86_64-linux with wayland. Should be good to go.

@yayayayaka yayayayaka merged commit a8c6ee0 into NixOS:release-24.11 May 20, 2025
35 of 37 checks passed
@teutat3s teutat3s deleted the feishin-backports branch July 15, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants