Skip to content

lx-music-desktop: bump electron version#419936

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
TomaSajt:lx-music-desktop
Jun 25, 2025
Merged

lx-music-desktop: bump electron version#419936
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
TomaSajt:lx-music-desktop

Conversation

@TomaSajt
Copy link
Copy Markdown
Contributor

@TomaSajt TomaSajt commented Jun 25, 2025

Tracking: #419903

Upstream has updated their node-abi in the meantime, so I'll remove that comment for now.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 25, 2025
@nix-owners nix-owners Bot requested a review from StarryReverie June 25, 2025 15:48
@TomaSajt TomaSajt mentioned this pull request Jun 25, 2025
Merged
22 tasks
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 25, 2025
@SuperSandro2000 SuperSandro2000 merged commit e769aa4 into NixOS:master Jun 25, 2025
30 of 32 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented Jul 1, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Jul 1, 2025
Merged
1 task
@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 1, 2025
@TomaSajt TomaSajt deleted the lx-music-desktop branch January 20, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

+1 more reviewer

@StarryReverie StarryReverie StarryReverie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomaSajt @SuperSandro2000 @StarryReverie @teutat3s