[Backport release-25.05] teleport_17: 17.5.3 -> 17.5.4; teleport_16: 16.5.11 -> 16.5.13 by nixpkgs-ci[bot] · Pull Request #423289 · NixOS/nixpkgs

nixpkgs-ci · 2025-07-07T18:55:34Z

Bot-based backport to release-25.05, triggered by a label in #422238.

Before merging, ensure that this backport is acceptable for the release.
- Even as a non-committer, if you find that it is not acceptable, leave a comment.

Changelog: https://github.com/gravitational/teleport/releases/tag/v17.5.4 Diff: gravitational/teleport@v17.5.3...v17.5.4 (cherry picked from commit 1916a8a)

Changelog: https://github.com/gravitational/teleport/releases/tag/v16.5.13 Diff: gravitational/teleport@v16.5.11...v16.5.13 (cherry picked from commit da3853e)

JuliusFreudenberger · 2025-07-07T20:29:29Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 423289

Logs: https://github.com/JuliusFreudenberger/nixpkgs-review-gha/actions/runs/16126229708

`x86_64-linux`

✅ 4 packages built:

teleport (teleport_17)
teleport.client (teleport_17.client)
teleport_16
teleport_16.client

`aarch64-linux`

✅ 4 packages built:

teleport (teleport_17)
teleport.client (teleport_17.client)
teleport_16
teleport_16.client

`x86_64-darwin` (sandbox = true)

❌ 2 packages failed to build:

teleport_16
teleport_16.client

✅ 2 packages built:

teleport (teleport_17)
teleport.client (teleport_17.client)

`aarch64-darwin` (sandbox = true)

❌ 2 packages failed to build:

teleport_16
teleport_16.client

✅ 2 packages built:

teleport (teleport_17)
teleport.client (teleport_17.client)

mdaniels5757 · 2025-07-08T13:46:32Z

+  version = "16.5.13";
+  hash = "sha256-X9Ujgvp+2dFCoku0tjGW4W05X8QrnExFE+H1kMhf91A=";
+  vendorHash = "sha256-0+7xbIONnZs7dPpfpHPmep+k4XxQE8TS/eKz4F5a3V0=";
+  pnpmHash = "sha256-waBzmNs20wbuoBDObVFnJjEYs3NJ/bzQksVz7ltMD7M=";


Suggested change

pnpmHash = "sha256-waBzmNs20wbuoBDObVFnJjEYs3NJ/bzQksVz7ltMD7M=";

pnpmHash = "sha256-IISTLreZSBrF1VDmXSDK6EFpn0o9sOxQDgDmwFNocRA=";

(per https://github.com/JuliusFreudenberger/nixpkgs-review-gha/actions/runs/16126229708/job/45503671368#step:6:1871)

Thanks. Was gone without laptop, so didn't have the capabilities to check.

But: Why?

@techknowlogick, you own a aarch64-darwin machine. Could you please double-check?

I suggest, this is similar to #407982 (comment) (and following links).
So a review on real hardware (not GHA runner) is really appreciated.

See my nixpkgs-review run. Does that mean pnpm.fetchDeps is not reproducible?

Ping @gepird and @Scrumplex who fixed some pnpm.fetchDeps reproducibility issue earlier this year.

Edit: Ah, found #422975 now, which could hopefully fix it?

#422975 fixes the permission mismatch when using pnpm.fetchDeps on different environments. If this is the cause, you'll be able to fix it by opting into a newer version:

# file: pkgs/by-name/te/teleport/package.nix pnpmDeps = pnpm_10.fetchDeps { inherit src pname version; hash = pnpmHash; fetcherVersion = 2; };

I'm getting the sha256-waBzmNs20wbuoBDObVFnJjEYs3NJ/bzQksVz7ltMD7M= hash, it would be helpful if you could share your pnpm deps with the sha256-IISTLreZSBrF1VDmXSDK6EFpn0o9sOxQDgDmwFNocRA= hash :)

It seems the only time the other hash appeared is in the GHA run in #423289 (comment) - so I think nobody has access to the actual result with the other hash.

Although I wonder whether the fact that this seems to be the only case where the sandbox was fully enabled (sandbox = true) plays a role? I assume all other tests were with a relaxed sandbox.

Is it possible for either of you to run it with fully enabled sandbox? I sadly don't have access to a Mac, so I cannot help here.

wolfgangwalther · 2025-07-09T17:18:55Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 423289
Commit: cfe8744d79862cf40b77ca315bee2644f61a834a

`x86_64-linux`

✅ 4 packages built:

teleport (teleport_17)
teleport.client (teleport_17.client)
teleport_16
teleport_16.client

`aarch64-linux`

✅ 4 packages built:

teleport (teleport_17)
teleport.client (teleport_17.client)
teleport_16
teleport_16.client

`x86_64-darwin`

✅ 4 packages built:

teleport (teleport_17)
teleport.client (teleport_17.client)
teleport_16
teleport_16.client

`aarch64-darwin`

✅ 4 packages built:

teleport (teleport_17)
teleport.client (teleport_17.client)
teleport_16
teleport_16.client

techknowlogick · 2025-07-09T17:41:32Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 423289

`aarch64-darwin`

✅ 4 packages built:

teleport (teleport_17)
teleport.client (teleport_17.client)
teleport_16
teleport_16.client

wolfgangwalther · 2025-07-15T16:01:34Z

Since there is no reason to assume that this hash is consistent on the release branch right now and the inconsistencies only introduced here, I think we should merge this with the current hash. That's no worse than what we already have, I think.

The "other" hash was only observed in a GHA run, so far. Everybody else had the hash that is currently in the code. Once this hits hydra (and assuming that hydra will be able to build it), this hash will then substitute the same FOD for everyone.

Thus, we should not block this PR on the instability of the fetcher. Any objection to merging, anyone?

JuliusFreudenberger

Let's do the merge.

needs to be solved elsewhere

JuliusFreudenberger added 2 commits July 7, 2025 18:55

teleport_17: 17.5.3 -> 17.5.4

ffc3177

Changelog: https://github.com/gravitational/teleport/releases/tag/v17.5.4 Diff: gravitational/teleport@v17.5.3...v17.5.4 (cherry picked from commit 1916a8a)

teleport_16: 16.5.11 -> 16.5.13

cfe8744

Changelog: https://github.com/gravitational/teleport/releases/tag/v16.5.13 Diff: gravitational/teleport@v16.5.11...v16.5.13 (cherry picked from commit da3853e)

nixpkgs-ci Bot added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jul 7, 2025

nixpkgs-ci Bot mentioned this pull request Jul 7, 2025

teleport_17: 17.5.3 -> 17.5.4; teleport_16: 16.5.11 -> 16.5.13 #422238

Merged

13 tasks

nix-owners Bot requested review from JuliusFreudenberger, arianvp, freezeboy, justinas, sigma, techknowlogick and tomberek July 7, 2025 18:57

nixpkgs-ci Bot added 4.workflow: backport This targets a stable branch 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 7, 2025

mdaniels5757 previously requested changes Jul 8, 2025

View reviewed changes

techknowlogick approved these changes Jul 9, 2025

View reviewed changes

nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 9, 2025

JuliusFreudenberger mentioned this pull request Jul 11, 2025

teleport_18: init at 18.1.1 #411095

Merged

13 tasks

JuliusFreudenberger approved these changes Jul 15, 2025

View reviewed changes

nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 15, 2025

wolfgangwalther merged commit 2ef493b into release-25.05 Jul 15, 2025
33 of 34 checks passed

wolfgangwalther deleted the backport-422238-to-release-25.05 branch July 15, 2025 19:44

	pnpmHash = "sha256-waBzmNs20wbuoBDObVFnJjEYs3NJ/bzQksVz7ltMD7M=";
	pnpmHash = "sha256-IISTLreZSBrF1VDmXSDK6EFpn0o9sOxQDgDmwFNocRA=";

Uh oh!

Conversation

nixpkgs-ci Bot commented Jul 7, 2025

Uh oh!

JuliusFreudenberger commented Jul 7, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wolfgangwalther Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wolfgangwalther commented Jul 9, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

techknowlogick commented Jul 9, 2025

nixpkgs-review result

aarch64-darwin

Uh oh!

wolfgangwalther commented Jul 15, 2025

Uh oh!

JuliusFreudenberger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

wolfgangwalther Jul 9, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

`nixpkgs-review` result

`aarch64-darwin`