[Backport release-25.05] chromium,chromedriver: 140.0.7339.207 -> 141.0.7390.54#447800
Merged
emilylange merged 2 commits intoNixOS:release-25.05from Oct 2, 2025
Merged
Conversation
This build target, mksnapshot, was added all the way back in 2014 in 8d54dc6 to add support for grsecurity. A few years later in 2017, grsecurity made their free testing patches private, forcing nixpkgs to drop the grsecurity-flavored linux kernel in 32b8512. Roughtly another year later, 1b146a8 removed paxutils from the stdenv and the remaining paxmark invocations in various build expressions. The explicit mksnapshot build target, however, remained, for no reason. In 2023, 0a05fbb renamed the target from mksnapshot to run_mksnapshot_default for cross-compilation reasons. Note that removing it does not improve compile times in any meaningful way. This is because mksnapshot is implicitly pulled in by the main build target, chrome. It does, however, make the ninja task count more accurate and build dependency errors that would previously only happen in chrome but not mksnapshot, no longer require to first build mksnapshot and instead fail immediately. (cherry picked from commit 658df01)
eb26d2a to
5cec7a4
Compare
Member
Author
Merged
via the queue into
NixOS:release-25.05
with commit Oct 2, 2025
c1bed91
29 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #447766 due of a merge-conflict caused by #434962.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.