Skip to content

[Backport release-25.05] chromium,chromedriver: 140.0.7339.207 -> 141.0.7390.54#447800

Merged
emilylange merged 2 commits intoNixOS:release-25.05from
emilylange:backport-447766-to-release-25.05
Oct 2, 2025
Merged

[Backport release-25.05] chromium,chromedriver: 140.0.7339.207 -> 141.0.7390.54#447800
emilylange merged 2 commits intoNixOS:release-25.05from
emilylange:backport-447766-to-release-25.05

Conversation

@emilylange
Copy link
Copy Markdown
Member

@emilylange emilylange commented Oct 1, 2025

Manual backport of #447766 due of a merge-conflict caused by #434962.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@emilylange emilylange added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 1, 2025
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 4.workflow: backport This targets a stable branch labels Oct 1, 2025
@nix-owners nix-owners Bot requested a review from networkException October 1, 2025 18:30
This build target, mksnapshot, was added all the way back in 2014 in
8d54dc6 to add support for grsecurity.

A few years later in 2017, grsecurity made their free testing patches
private, forcing nixpkgs to drop the grsecurity-flavored linux
kernel in 32b8512.

Roughtly another year later, 1b146a8
removed paxutils from the stdenv and the remaining paxmark invocations
in various build expressions. The explicit mksnapshot build target,
however, remained, for no reason.

In 2023, 0a05fbb renamed the target
from mksnapshot to run_mksnapshot_default for cross-compilation reasons.

Note that removing it does not improve compile times in any meaningful
way. This is because mksnapshot is implicitly pulled in by the main
build target, chrome. It does, however, make the ninja task count
more accurate and build dependency errors that would previously only
happen in chrome but not mksnapshot, no longer require to first build
mksnapshot and instead fail immediately.

(cherry picked from commit 658df01)
@emilylange emilylange force-pushed the backport-447766-to-release-25.05 branch from eb26d2a to 5cec7a4 Compare October 2, 2025 01:18
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 2, 2025
@emilylange
Copy link
Copy Markdown
Member Author

Had to drop 713691f because #445467 hasn't been merged yet. Not sure how I missed that.

@emilylange emilylange added this pull request to the merge queue Oct 2, 2025
Merged via the queue into NixOS:release-25.05 with commit c1bed91 Oct 2, 2025
29 of 33 checks passed
@emilylange emilylange deleted the backport-447766-to-release-25.05 branch October 2, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant