Skip to content

webcord(-vencord): bump electron to v37#459739

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
bengsparks:webcord-electron
Nov 18, 2025
Merged

webcord(-vencord): bump electron to v37#459739
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
bengsparks:webcord-electron

Conversation

@bengsparks
Copy link
Copy Markdown
Contributor

@bengsparks bengsparks commented Nov 8, 2025

Tracking PR / issue: #458485.
I managed to build the package on darwin as well, but I'm not able to test it right now.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@bengsparks bengsparks changed the title webcord: bump electron to v37 webcord(-vencord): bump electron to v37 Nov 8, 2025
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Nov 8, 2025
@bengsparks
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 459739
Commit: 7603716186557469fd7757f72e2d5209ff0d7317


x86_64-linux

✅ 2 packages built:
  • webcord
  • webcord-vencord

aarch64-linux

✅ 2 packages built:
  • webcord
  • webcord-vencord

@bengsparks bengsparks marked this pull request as ready for review November 8, 2025 13:15
@NotAShelf
Copy link
Copy Markdown
Member

Why was the update script removed?

@bengsparks
Copy link
Copy Markdown
Contributor Author

Because it didnt work 🤷 I ran nix-shell maintainers/scripts/update.nix on the webcord package, and nothing was bumped. It is my understanding that the update scripts exist to bump their package, not their dependencies?

@huantianad
Copy link
Copy Markdown
Contributor

That's to be expected; the update script will only do something if upstream releases a new version. When that happens, it will update the pinned electron version to whatever upstream sets it to.

@niklaskorz
Copy link
Copy Markdown
Member

niklaskorz commented Nov 9, 2025

If upstream does not manage to leave a certain version of Electron behind before it reaches EOL (as has happened here), I agree the custom update script does more harm than good.

@huantianad
Copy link
Copy Markdown
Contributor

huantianad commented Nov 9, 2025

It does no harm though? Like the normal upgrade script would've also done nothing...

Copy link
Copy Markdown
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with dropping the update script, the whole point was to make electron bumps automatic.
See 7030416

Since the electron version is directly in the package expression now, the file and regex just needs to be changed slightly.

sed -r "s|(electron_)[0-9]+|\1$electronVersion|" -i pkgs/by-name/we/webcord/package.nix

Please drop bengsparks@7603716 and apply the above.
The same update script would have to be copied into webcord-vencord's directory and the path adjusted of course.

And then we should update the two in-tandem.
(Actually I will probably just propose a new PR at this point.)

@bengsparks
Copy link
Copy Markdown
Contributor Author

bengsparks commented Nov 10, 2025

I'll drop the commit and apply the changes 👍

Copy link
Copy Markdown
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures they're updated together

Comment thread pkgs/by-name/we/webcord/update.sh Outdated
@eclairevoyant
Copy link
Copy Markdown
Contributor

eclairevoyant commented Nov 10, 2025

The same update script would have to be copied into webcord-vencord's directory and the path adjusted of course.

This was incorrect on my part, I forgot webcord-vencord was just an override of webcord. So we'll want to not-set any update script for webcord-vencord.
My change above should suffice instead.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 10, 2025
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 11, 2025
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Nov 18, 2025
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Nov 18, 2025
Merged via the queue into NixOS:master with commit e0652ba Nov 18, 2025
35 of 36 checks passed
@bengsparks bengsparks deleted the webcord-electron branch November 18, 2025 22:33
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented Nov 18, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-459739-to-release-25.05 origin/release-25.05
cd .worktree/backport-459739-to-release-25.05
git switch --create backport-459739-to-release-25.05
git cherry-pick -x 30e8e817989c7ae2b427dca7f978fff6db3b934e 9eec9c1c29d6a0f98a1de2a840bd880c163c857d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants