webcord(-vencord): bump electron to v37#459739
Conversation
45e5485 to
a9e839e
Compare
a9e839e to
7603716
Compare
|
|
Why was the update script removed? |
|
Because it didnt work 🤷 I ran |
|
That's to be expected; the update script will only do something if upstream releases a new version. When that happens, it will update the pinned electron version to whatever upstream sets it to. |
|
If upstream does not manage to leave a certain version of Electron behind before it reaches EOL (as has happened here), I agree the custom update script does more harm than good. |
|
It does no harm though? Like the normal upgrade script would've also done nothing... |
There was a problem hiding this comment.
I disagree with dropping the update script, the whole point was to make electron bumps automatic.
See 7030416
Since the electron version is directly in the package expression now, the file and regex just needs to be changed slightly.
sed -r "s|(electron_)[0-9]+|\1$electronVersion|" -i pkgs/by-name/we/webcord/package.nix
Please drop bengsparks@7603716 and apply the above.
The same update script would have to be copied into webcord-vencord's directory and the path adjusted of course.
And then we should update the two in-tandem.
(Actually I will probably just propose a new PR at this point.)
|
I'll drop the commit and apply the changes 👍 |
7603716 to
3110a1a
Compare
eclairevoyant
left a comment
There was a problem hiding this comment.
This ensures they're updated together
3110a1a to
0be2aee
Compare
This was incorrect on my part, I forgot |
0be2aee to
9eec9c1
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-459739-to-release-25.05 origin/release-25.05
cd .worktree/backport-459739-to-release-25.05
git switch --create backport-459739-to-release-25.05
git cherry-pick -x 30e8e817989c7ae2b427dca7f978fff6db3b934e 9eec9c1c29d6a0f98a1de2a840bd880c163c857d |
Tracking PR / issue: #458485.
I managed to build the package on darwin as well, but I'm not able to test it right now.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.