podman-desktop: 1.22.1 -> 1.23.1, update fetcherVersion#463074
podman-desktop: 1.22.1 -> 1.23.1, update fetcherVersion#463074yayayayaka merged 3 commits intoNixOS:masterfrom
Conversation
|
Thanks. I can confirm the version = 2 fixes the issue, and the hash is correct. But this bump seems to break Darwin. I get this error when starting the app: I will check if Linux is also broken in a few minutes and update. |
|
On Linux the app also crashes on startup: I don't have debug symbols installed but I'd assume the trace will be similar to Darwin's. |
This comment was marked as resolved.
This comment was marked as resolved.
|
My reading of v8 code suggests that the wasm trap handler was set twice, which is forbidden: We are aborted by |
|
I think we hit electron/electron#48975 |
We need a newer electron_39. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@kachick why closing it though? I'm going to post a bump request for |
|
In case you are curious, there are some details about what exactly happens (in some crashing apps) here: electron/electron#48983 |
This comment was marked as resolved.
This comment was marked as resolved.
|
I'd just keep it as draft for now. |
|
electron_39 bump: #463086 |
The hash appears flaky when building on GitHub-hosted Linux runners. As far as I see, applying the new fetcher introduced in 0eec779 makes the result stable.
51f0686 to
2a6f565
Compare
|
The coredump is gone. The dashboard now starts on x86_64-darwin and x86_64-linux (X11). I am unsure if this is related to issue podman-desktop/podman-desktop#14123, since I could launch the dashboard on Wayland with current XDG_SESSION_TYPE=x11 nix run .#podman-desktop
|
|
Thanks for digging out the electron wayland issue! I tried it on my Linux desktop (barebones hyprland) and yes - the app correctly opens the window but the DPI looked crappy. See screenshot. (Note blurred fonts.)
Maybe I'm not configuring x11 emulation properly, not sure. But I didn't have this issue with the Wayland backend. Any ideas? I see electron/electron#48600 was merged and is supposed to be the fix for the original issue that required the x11 hack. But it was included in electron-39-x-y branch, so I wonder what's going on here... And here someone was complaining that while a fix in Electron fixed crashes, the window not showing up is still an issue: podman-desktop/podman-desktop#14123 (comment) |
This is not true for me. If I run it from Which makes me think that perhaps the dashboard missing issue is not specific to this bump - and perhaps better handled separately from this PR. I'd drop the x11 patch and land the version bump for now. WDYT? UPD: nevermind, I think my issue with blurry app was because xwayland wasn't configured to unscale wayland scaling. The blurriness was fixed for me with this change to my home manager config: booxter/nix@167dad2 Since there's a fix for the blurriness, I'm ok with merging the PR as-is. |
|
@NixOS/nixpkgs-merge-bot merge |
|
@booxter wants to merge this PR. Requirements to merge this PR with
❌ Pull Request could not be merged (#305350) |
|
Thank you all for reviewing and merging! |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.11
git worktree add -d .worktree/backport-463074-to-release-25.11 origin/release-25.11
cd .worktree/backport-463074-to-release-25.11
git switch --create backport-463074-to-release-25.11
git cherry-pick -x 32bd90eb01f2af531d36dba6972f5996f083fac0 2a6f565c7a3c0fc614255bb8c036f8f3c264eabd 23a7d2e45ed7c5acdecc533b2bd5a715832fe6bc |


Dif: podman-desktop/podman-desktop@v1.22.1...v1.23.1
ref: #462421 (comment), #361460 (comment), #407982 (comment)
This PR includes and supersedes #462421
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.cc: @booxter
Add a 👍 reaction to pull requests you find important.