Skip to content

podman-desktop: 1.22.1 -> 1.23.1, update fetcherVersion#463074

Merged
yayayayaka merged 3 commits intoNixOS:masterfrom
kachick:podman-desktop-fetcher-v2
Nov 26, 2025
Merged

podman-desktop: 1.22.1 -> 1.23.1, update fetcherVersion#463074
yayayayaka merged 3 commits intoNixOS:masterfrom
kachick:podman-desktop-fetcher-v2

Conversation

@kachick
Copy link
Copy Markdown
Member

@kachick kachick commented Nov 19, 2025

Dif: podman-desktop/podman-desktop@v1.22.1...v1.23.1

ref: #462421 (comment), #361460 (comment), #407982 (comment)

This PR includes and supersedes #462421

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

cc: @booxter


Add a 👍 reaction to pull requests you find important.

@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 19, 2025

Thanks. I can confirm the version = 2 fixes the issue, and the hash is correct.


But this bump seems to break Darwin. I get this error when starting the app:

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------
Process:             .Podman Desktop-wrapped [39613]
Path:                /Volumes/VOLUME/*/Podman Desktop.app/Contents/MacOS/.Podman Desktop-wrapped
Identifier:          .Podman Desktop-wrapped
Version:             ???
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           io.podmandesktop.PodmanDesktop [37499]
User ID:             501

Date/Time:           2025-11-18 22:29:08.8288 -0500
Launch Time:         2025-11-18 22:29:08.2039 -0500
Hardware Model:      Mac16,10
OS Version:          macOS 26.0.1 (25A362)
Release Type:        User

Crash Reporter Key:  1F83FC7E-79D0-6E3E-3CC4-BC2DCF710B9E
Incident Identifier: 019DBE15-BF0F-4848-84B2-9909156C00BF

Time Awake Since Boot: 960000 seconds

System Integrity Protection: enabled

Triggered by Thread: 0

Exception Type:    EXC_BREAKPOINT (SIGTRAP)
Exception Codes:   0x0000000000000001, 0x0000000111548140

Termination Reason:  Namespace SIGNAL, Code 5, Trace/BPT trap: 5
Terminating Process: exc handler [39613]


Thread 0 Crashed:
0   Electron Framework            	       0x111548140 v8::V8::EnableWebAssemblyTrapHandler(bool) + 100
1   Electron Framework            	       0x11244b50c v8::CpuProfileNode::GetNodeId() const + 162012
2   Electron Framework            	       0x111ccd4f4 rust_png$cxxbridge1$Reader$try_get_chrm + 187688
3   Electron Framework            	       0x113ca068c _v8_internal_Node_Print(void*) + 5989516
4   Electron Framework            	       0x1119fbe24 node::PrincipalRealm::wasm_streaming_object_constructor() const + 54672
5   Electron Framework            	       0x1119fbd4c node::PrincipalRealm::wasm_streaming_object_constructor() const + 54456
6   Electron Framework            	       0x11160e690 node::inspector::protocol::Value::AppendSerialized(std::__Cr::vector<unsigned char, std::__Cr::allocator<unsigned char>>*) const + 71688
7   Electron Framework            	       0x11160b014 node::inspector::protocol::Value::AppendSerialized(std::__Cr::vector<unsigned char, std::__Cr::allocator<unsigned char>>*) const + 57740
8   Electron Framework            	       0x1118963bc v8::Message::GetScriptOrigin() const + 22332
9   Electron Framework            	       0x111895d7c v8::Message::GetScriptOrigin() const + 20732
10  Electron Framework            	       0x11235caec ElectronMain + 124
11  dyld                          	       0x181fadd54 start + 7184

I will check if Linux is also broken in a few minutes and update.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 19, 2025
@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 19, 2025

On Linux the app also crashes on startup:

$ ./result/bin/podman-desktop
(node:1184139) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `electron --trace-deprecation ...` to show where the warning was created)
zsh: trace trap (core dumped)  ./result/bin/podman-desktop
$ coredumpctl dump
           PID: 1183561 (electron)
           UID: 1000 (ihrachyshka)
           GID: 998 (ihrachyshka)
        Signal: 5 (TRAP)
     Timestamp: Tue 2025-11-18 22:35:26 EST (1min 5s ago)
  Command Line: /nix/store/bzpa6q5dx774xhjldf0dh34zddszhq9g-electron-unwrapped-39.2.0/libexec/electron/electron/nix/store/f9h7zhwdnsaf2x9638slva9l1d6bjfy7-podman-desktop-1.23.1/share/lib/podman-desktop/resources/app.asar
    Executable: /nix/store/bzpa6q5dx774xhjldf0dh34zddszhq9g-electron-unwrapped-39.2.0/libexec/electron/electron
 Control Group: /user.slice/user-1000.slice/user@1000.service/kitty-2055366-0.scope
          Unit: user@1000.service
     User Unit: kitty-2055366-0.scope
         Slice: user-1000.slice
     Owner UID: 1000 (ihrachyshka)
       Boot ID: 2aad60f3e5cd431084070dae17c78052
    Machine ID: 2ed4fd4556c74d1b974cc7a4225496b8
      Hostname: frame
       Storage: /var/lib/systemd/coredump/core.electron.1000.2aad60f3e5cd431084070dae17c78052.1183561.1763523326000000.zst (truncated)
  Size on Disk: 43.2M
       Message: Process 1183561 (electron) of user 1000 dumped core.

                Stack trace of thread 1183561:
                #0  0x0000557fea4c69f6 n/a (n/a + 0x0)
                ELF object binary architecture: AMD x86-64
Refusing to dump core to tty (use shell redirection or specify --output).
-- Notice: 1 systemd-coredump@.service unit is running, output may be incomplete.

I don't have debug symbols installed but I'd assume the trace will be similar to Darwin's.

@kachick

This comment was marked as resolved.

@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 19, 2025

My reading of v8 code suggests that the wasm trap handler was set twice, which is forbidden:

bool g_is_trap_handler_enabled{false};
std::atomic<bool> g_can_enable_trap_handler{true};

bool EnableTrapHandler(bool use_v8_handler) {
  // We should only enable the trap handler once, and before any call to
  // {IsTrapHandlerEnabled}. Enabling the trap handler late can lead to problems
  // because code or objects might have been generated under the assumption that
  // trap handlers are disabled.
  bool can_enable =
      g_can_enable_trap_handler.exchange(false, std::memory_order_relaxed);
  // EnableTrapHandler called twice, or after IsTrapHandlerEnabled.
  TH_CHECK(can_enable);
  if (!V8_TRAP_HANDLER_SUPPORTED) {
    return false;
  }

  // "Warm-up" the TrapHandlerGuard mechanism to ensure that if any
  // initialization is required for its thread-local storage, it is done now
  // and not inside the signal handler. We're being extra cautious here, it's
  // unclear if this is really necessary.
  TrapHandlerGuard active_guard;

  if (use_v8_handler) {
    g_is_trap_handler_enabled = RegisterDefaultTrapHandler();
    return g_is_trap_handler_enabled;
  }
  g_is_trap_handler_enabled = true;
  return true;
}

We are aborted by TH_CHECK call that validates that this function is called once with true.

@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 19, 2025

I think we hit electron/electron#48975

@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 19, 2025

git tag --contains eecca2cb199b481a891f83f6dfb946fb4849e4b9
v39.2.1
v39.2.2

We need a newer electron_39.

@kachick

This comment was marked as resolved.

@kachick kachick closed this Nov 19, 2025
@kachick kachick deleted the podman-desktop-fetcher-v2 branch November 19, 2025 04:48
@kachick

This comment was marked as off-topic.

@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 19, 2025

@kachick why closing it though? I'm going to post a bump request for electron_39 in a few. Once we merge the electron bump, we can land this PR.

@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 19, 2025

In case you are curious, there are some details about what exactly happens (in some crashing apps) here: electron/electron#48983

@kachick

This comment was marked as resolved.

@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 19, 2025

I'd just keep it as draft for now.

@kachick kachick restored the podman-desktop-fetcher-v2 branch November 19, 2025 05:01
@kachick kachick reopened this Nov 19, 2025
@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 19, 2025

electron_39 bump: #463086

r-ryantm and others added 2 commits November 22, 2025 11:46
The hash appears flaky when building on GitHub-hosted Linux runners.
As far as I see, applying the new fetcher introduced in 0eec779
makes the result stable.
@kachick kachick force-pushed the podman-desktop-fetcher-v2 branch from 51f0686 to 2a6f565 Compare November 22, 2025 02:46
@kachick
Copy link
Copy Markdown
Member Author

kachick commented Nov 22, 2025

The coredump is gone. The dashboard now starts on x86_64-darwin and x86_64-linux (X11).
However, the dashboard does not show up when starting on x86_64-linux (Wayland).

I am unsure if this is related to issue podman-desktop/podman-desktop#14123, since I could launch the dashboard on Wayland with current 1.22.1 + electron_38.
Should we add a workaround similar to podman-desktop/podman-desktop#14383?

XDG_SESSION_TYPE=x11 nix run .#podman-desktop
Screenshot From 2025-11-22 20-09-26

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463074
Commit: 2a6f565c7a3c0fc614255bb8c036f8f3c264eabd


x86_64-linux

✅ 1 package built:
  • podman-desktop

aarch64-linux

✅ 1 package built:
  • podman-desktop

x86_64-darwin

✅ 1 package built:
  • podman-desktop

aarch64-darwin

✅ 1 package built:
  • podman-desktop

@kachick kachick marked this pull request as ready for review November 22, 2025 18:37
@nixpkgs-ci nixpkgs-ci Bot requested a review from booxter November 22, 2025 20:51
@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 25, 2025

Thanks for digging out the electron wayland issue!


I tried it on my Linux desktop (barebones hyprland) and yes - the app correctly opens the window but the DPI looked crappy. See screenshot. (Note blurred fonts.)

image

Maybe I'm not configuring x11 emulation properly, not sure. But I didn't have this issue with the Wayland backend. Any ideas?


I see electron/electron#48600 was merged and is supposed to be the fix for the original issue that required the x11 hack. But it was included in electron-39-x-y branch, so I wonder what's going on here... And here someone was complaining that while a fix in Electron fixed crashes, the window not showing up is still an issue: podman-desktop/podman-desktop#14123 (comment)

@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 26, 2025

I am unsure if this is related to issue podman-desktop/podman-desktop#14123, since I could launch the dashboard on Wayland with current 1.22.1 + electron_38.

This is not true for me. If I run it from c8d4dabc4357a22d1c249a9363998bdb00122544 that was the last version we built from electron_37, then the window is popping up (blurred!) while with current version (built with electron 38) it doesn't.

Which makes me think that perhaps the dashboard missing issue is not specific to this bump - and perhaps better handled separately from this PR. I'd drop the x11 patch and land the version bump for now. WDYT?


UPD: nevermind, I think my issue with blurry app was because xwayland wasn't configured to unscale wayland scaling. The blurriness was fixed for me with this change to my home manager config: booxter/nix@167dad2

Since there's a fix for the blurriness, I'm ok with merging the PR as-is.

@booxter
Copy link
Copy Markdown
Contributor

booxter commented Nov 26, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented Nov 26, 2025

@booxter wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ❌ PR is at least one of:
    • ⬜ Approved by a committer.
    • ⬜ Backported via label.
    • ⬜ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ booxter is a member of @NixOS/nixpkgs-maintainers.
  • ✅ booxter is a maintainer of all touched packages.

❌ Pull Request could not be merged (#305350)

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 26, 2025
@yayayayaka yayayayaka added this pull request to the merge queue Nov 26, 2025
Merged via the queue into NixOS:master with commit 50d7f2b Nov 26, 2025
34 of 35 checks passed
@kachick
Copy link
Copy Markdown
Member Author

kachick commented Nov 26, 2025

Thank you all for reviewing and merging!

@kachick kachick deleted the podman-desktop-fetcher-v2 branch November 26, 2025 17:45
@teutat3s teutat3s added the backport release-25.11 Backport PR automatically label Mar 21, 2026
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented Mar 21, 2026

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.11
git worktree add -d .worktree/backport-463074-to-release-25.11 origin/release-25.11
cd .worktree/backport-463074-to-release-25.11
git switch --create backport-463074-to-release-25.11
git cherry-pick -x 32bd90eb01f2af531d36dba6972f5996f083fac0 2a6f565c7a3c0fc614255bb8c036f8f3c264eabd 23a7d2e45ed7c5acdecc533b2bd5a715832fe6bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants