Skip to content

[25.05] joplin-desktop: update electron 36 -> 37#463211

Merged
yayayayaka merged 1 commit intoNixOS:release-25.05from
fugidev:backport-460058-to-release-25.05
Nov 21, 2025
Merged

[25.05] joplin-desktop: update electron 36 -> 37#463211
yayayayaka merged 1 commit intoNixOS:release-25.05from
fugidev:backport-460058-to-release-25.05

Conversation

@fugidev
Copy link
Copy Markdown
Member

@fugidev fugidev commented Nov 19, 2025 •
edited by yayayayaka
Loading

Manual backport of #460058 needed because of #461995.

Not built myself because electron_37 is not cached for some reason and I'm not compiling that.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@bjornfor @fugidev
joplin-desktop: update electron 36 -> 37
5440036 
Fixes the build, as electron_36 is EOL and use of it results in eval
error.

(cherry picked from commit c0886dc)
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 4.workflow: backport This targets a stable branch labels Nov 19, 2025
@teutat3s teutat3s mentioned this pull request Nov 20, 2025
Merged
28 tasks
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 20, 2025
yayayayaka
yayayayaka approved these changes Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux

@yayayayaka yayayayaka added this pull request to the merge queue Nov 21, 2025
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 21, 2025
Merged via the queue into NixOS:release-25.05 with commit c8d6732 Nov 21, 2025
40 of 41 checks passed
@fugidev fugidev deleted the backport-460058-to-release-25.05 branch November 28, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yayayayaka yayayayaka yayayayaka approved these changes

@teutat3s teutat3s Awaiting requested review from teutat3s

@TomaSajt TomaSajt Awaiting requested review from TomaSajt

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fugidev @yayayayaka @bjornfor