Skip to content

python313Packages.splinter: fix build with lxml 6 #465719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dotlambda merged 2 commits into from
Nov 29, 2025
Merged

python313Packages.splinter: fix build with lxml 6 #465719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b055793
python313Packages.splinter: fix build with lxml 6
thunze Nov 28, 2025
98d1634
python313Packages.splinter: modernize
thunze Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions pkgs/development/python-modules/splinter/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
lib,
buildPythonPackage,
pythonOlder,
fetchFromGitHub,
setuptools,
urllib3,
Expand All @@ -17,9 +16,6 @@
buildPythonPackage rec {
pname = "splinter";
version = "0.21.0";

disabled = pythonOlder "3.8";

pyproject = true;

src = fetchFromGitHub {
Expand All @@ -29,9 +25,13 @@ buildPythonPackage rec {
hash = "sha256-PGGql8yI1YosoUBAyDoI/8k7s4sVYnXEV7eow3GHH88=";
};

nativeBuildInputs = [ setuptools ];
patches = [
./lxml-6.patch
];

build-system = [ setuptools ];

propagatedBuildInputs = [ urllib3 ];
dependencies = [ urllib3 ];

optional-dependencies = {
"zope.testbrowser" = [
Expand Down Expand Up @@ -84,11 +84,11 @@ buildPythonPackage rec {

pythonImportsCheck = [ "splinter" ];

meta = with lib; {
meta = {
changelog = "https://splinter.readthedocs.io/en/latest/news.html";
description = "Browser abstraction for web acceptance testing";
homepage = "https://github.com/cobrateam/splinter";
license = licenses.bsd3;
maintainers = with maintainers; [ dotlambda ];
license = lib.licenses.bsd3;
maintainers = with lib.maintainers; [ dotlambda ];
};
}
42 changes: 42 additions & 0 deletions pkgs/development/python-modules/splinter/lxml-6.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
diff --git a/tests/fake_django/urls.py b/tests/fake_django/urls.py
index 2ab75ff..bd736ab 100644
--- a/tests/fake_django/urls.py
+++ b/tests/fake_django/urls.py
@@ -52,7 +52,8 @@ def post_form(request):


def request_headers(request):
- body = "\n".join(f"{key}: {value}" for key, value in request.META.items())
+ headers = "\n".join(f"{key}: {value}" for key, value in request.META.items())
+ body = f"<html><body>{headers}</body></html>"
return HttpResponse(body)


@@ -67,7 +68,7 @@ def upload_file(request):


def foo(request):
- return HttpResponse("BAR!")
+ return HttpResponse("<html><body>BAR!</body></html>")


def query_string(request):
diff --git a/tests/fake_webapp.py b/tests/fake_webapp.py
index ccd5bab..efc31c5 100644
--- a/tests/fake_webapp.py
+++ b/tests/fake_webapp.py
@@ -119,12 +119,12 @@ def upload_file():

@app.route("/headers", methods=["GET"])
def request_headers():
- return str(request.headers)
+ return f"<html><body>{request.headers}</body></html>"


@app.route("/foo")
def foo():
- return "BAR!"
+ return "<html><body>BAR!</body></html>"


@app.route("/query", methods=["GET"])
Loading