nixos/cloudflared: allow systemd credentials as relative paths#511198
Open
sepointon wants to merge 1 commit intoNixOS:masterfrom
Open
nixos/cloudflared: allow systemd credentials as relative paths#511198sepointon wants to merge 1 commit intoNixOS:masterfrom
sepointon wants to merge 1 commit intoNixOS:masterfrom
Conversation
Previously, credentialsFile had to be absolute. This made using systemd credentials annoying, as credential names aren't absolute. This made passing the cloudflared credential around as a systemd credential somewhat annoying, which is painful because systemd credentials are great for plumbing secrets around systemd containers. Allowing systemd credential names actually requires no config changes, only options schema changes: LoadCredential looks up non-absolute paths relative to the credential search path, so the right thing will happen just by allowing paths to be relative.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, credentialsFile had to be absolute. This made using systemd credentials annoying, as credential names aren't absolute. This made passing the cloudflared credential around as a systemd credential somewhat annoying, which is painful because systemd credentials are great for plumbing secrets around systemd containers.
Allowing systemd credential names actually requires no config changes, only options schema changes: LoadCredential looks up non-absolute paths relative to the credential search path, so the right thing will happen just by allowing paths to be relative.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.