fix: repair CI build broken by Free tier agent-limit bump - #547
Merged
Conversation
IngestAsync_WhenAgentLimitReached_DropsTraceForNewAgent relied on the Free tier capping MaxAgents at 1. Raising that cap to 2 broke the test. Inject a license substitute that caps MaxAgents at 1 explicitly (other limits stay unlimited), so the test verifies the drop-on-limit behavior independent of the Free tier's configured value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2NRNGHxoyq4vWo5b9uyeg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
masteris red. The single failing test is:Cause
PR #545 ("Raise Free tier agent and test-suite limits to 2") bumped
LicenseLimit.MaxAgentsin the Free tier from 1 to 2. This test hard-coded the assumption that the default Free license caps non-system agents at 1, so a second distinct agent is now allowed instead of dropped, and the assertions fail.PR #545 updated
LicensePolicyTests.csbut missed this ingestion test.Fix
Decouple the test from the Free tier's configured value: inject an
ILicenseServicesubstitute that capsMaxAgentsat 1 explicitly (other limits stay unlimited). This mirrors the sibling testIngestAsync_WhenAgentLimitUnlimited_CreatesSecondAgent, which already stubs the license. The test now verifies the drop-on-limit behavior regardless of what the Free tier limit is set to.Verification
🤖 Generated with Claude Code
Generated by Claude Code